From c7a5889b9ca5d11983c7326374eb9b3a9115755e Mon Sep 17 00:00:00 2001
From: Victor Wiebe <victor.wiebe@polymath.network>
Date: Thu, 21 Nov 2019 07:41:50 -0800
Subject: [PATCH] refactor: add prettier, rectify procedureTypes without
 hardcode string

---
 src/procedures/__tests__/AssignSecurityTokenRole.ts    | 10 ++++++++--
 src/procedures/__tests__/AssignStoRole.ts              |  4 ++--
 src/procedures/__tests__/EnableDividendManagers.ts     |  4 ++--
 .../__tests__/EnableGeneralPermissionManager.ts        |  4 ++--
 src/procedures/__tests__/PauseSto.ts                   |  1 +
 5 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/procedures/__tests__/AssignSecurityTokenRole.ts b/src/procedures/__tests__/AssignSecurityTokenRole.ts
index 56066e2..1e211ac 100644
--- a/src/procedures/__tests__/AssignSecurityTokenRole.ts
+++ b/src/procedures/__tests__/AssignSecurityTokenRole.ts
@@ -8,7 +8,13 @@ import * as tokenFactoryModule from '../../testUtils/MockedTokenFactoryModule';
 import { AssignSecurityTokenRole } from '../../procedures/AssignSecurityTokenRole';
 import { Procedure } from '../Procedure';
 import { PolymathError } from '../../PolymathError';
-import { ErrorCode, Feature, PolyTransactionTag, SecurityTokenRole } from '../../types';
+import {
+  ErrorCode,
+  Feature,
+  PolyTransactionTag,
+  ProcedureType,
+  SecurityTokenRole,
+} from '../../types';
 import * as securityTokenFactoryModule from '../../entities/factories/SecurityTokenFactory';
 import { mockFactories } from '../../testUtils/mockFactories';
 
@@ -76,7 +82,7 @@ describe('AssignSecurityTokenRole', () => {
   describe('Types', () => {
     test('should extend procedure and have AssignSecurityTokenRole type', async () => {
       expect(target instanceof Procedure).toBe(true);
-      expect(target.type).toBe('AssignSecurityTokenRole');
+      expect(target.type).toBe(ProcedureType.AssignSecurityTokenRole);
     });
   });
 
diff --git a/src/procedures/__tests__/AssignStoRole.ts b/src/procedures/__tests__/AssignStoRole.ts
index dc773c1..b12aaa3 100644
--- a/src/procedures/__tests__/AssignStoRole.ts
+++ b/src/procedures/__tests__/AssignStoRole.ts
@@ -7,7 +7,7 @@ import * as tokenFactoryModule from '../../testUtils/MockedTokenFactoryModule';
 import { AssignStoRole } from '../../procedures/AssignStoRole';
 import { Procedure } from '../Procedure';
 import { PolymathError } from '../../PolymathError';
-import { ErrorCode, PolyTransactionTag, StoRole } from '../../types';
+import { ErrorCode, PolyTransactionTag, ProcedureType, StoRole } from '../../types';
 
 const params = {
   symbol: 'TEST1',
@@ -46,7 +46,7 @@ describe('AssignStoRole', () => {
   describe('Types', () => {
     test('should extend procedure and have AssignStoRole type', async () => {
       expect(target instanceof Procedure).toBe(true);
-      expect(target.type).toBe('AssignStoRole');
+      expect(target.type).toBe(ProcedureType.AssignStoRole);
     });
   });
 
diff --git a/src/procedures/__tests__/EnableDividendManagers.ts b/src/procedures/__tests__/EnableDividendManagers.ts
index 84c8d7d..344df0a 100644
--- a/src/procedures/__tests__/EnableDividendManagers.ts
+++ b/src/procedures/__tests__/EnableDividendManagers.ts
@@ -8,7 +8,7 @@ import * as tokenFactoryModule from '../../testUtils/MockedTokenFactoryModule';
 import { EnableDividendManagers } from '../../procedures/EnableDividendManagers';
 import { Procedure } from '../Procedure';
 import { PolymathError } from '../../PolymathError';
-import { ErrorCode, PolyTransactionTag } from '../../types';
+import { ErrorCode, PolyTransactionTag, ProcedureType } from '../../types';
 
 const params = {
   symbol: 'TEST1',
@@ -57,7 +57,7 @@ describe('EnableDividendManagers', () => {
   describe('Types', () => {
     test('should extend procedure and have EnableDividendManagers type', async () => {
       expect(target instanceof Procedure).toBe(true);
-      expect(target.type).toBe('EnableDividendManagers');
+      expect(target.type).toBe(ProcedureType.EnableDividendManagers);
     });
   });
 
diff --git a/src/procedures/__tests__/EnableGeneralPermissionManager.ts b/src/procedures/__tests__/EnableGeneralPermissionManager.ts
index 3dca716..f03f214 100644
--- a/src/procedures/__tests__/EnableGeneralPermissionManager.ts
+++ b/src/procedures/__tests__/EnableGeneralPermissionManager.ts
@@ -8,7 +8,7 @@ import * as tokenFactoryModule from '../../testUtils/MockedTokenFactoryModule';
 import { EnableGeneralPermissionManager } from '../../procedures/EnableGeneralPermissionManager';
 import { Procedure } from '../Procedure';
 import { PolymathError } from '../../PolymathError';
-import { ErrorCode, PolyTransactionTag } from '../../types';
+import { ErrorCode, PolyTransactionTag, ProcedureType } from '../../types';
 
 const params = {
   symbol: 'TEST1',
@@ -56,7 +56,7 @@ describe('EnableGeneralPermissionManager', () => {
   describe('Types', () => {
     test('should extend procedure and have EnableGeneralPermissionManager type', async () => {
       expect(target instanceof Procedure).toBe(true);
-      expect(target.type).toBe('EnableGeneralPermissionManager');
+      expect(target.type).toBe(ProcedureType.EnableGeneralPermissionManager);
     });
   });
 
diff --git a/src/procedures/__tests__/PauseSto.ts b/src/procedures/__tests__/PauseSto.ts
index d9adeca..b8b8172 100644
--- a/src/procedures/__tests__/PauseSto.ts
+++ b/src/procedures/__tests__/PauseSto.ts
@@ -100,6 +100,7 @@ describe('PauseSto', () => {
     // Instantiate PauseSto
     target = new PauseSto(cappedParams, contextMock.getMockInstance());
   });
+
   afterEach(() => {
     restore();
   });