Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Consistently use the new name #25

Merged
merged 2 commits into from Oct 25, 2016
Merged

Consistently use the new name #25

merged 2 commits into from Oct 25, 2016

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Oct 22, 2016

No description provided.

@rictic rictic mentioned this pull request Oct 22, 2016
Closed
TimvdLippe
TimvdLippe approved these changes Oct 22, 2016
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are still named atom-polymer, do we want to change these too? Other than that LGTM.

usergenic
usergenic approved these changes Oct 25, 2016
View reviewed changes
src/atom-polymer.ts
@@ -13,7 +13,7 @@ import * as autocomplete from 'atom-autocomplete-plus';

interface ViewState {}

class AtomPolymer {
class PolymerIde {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to rename file before merge.

@rictic
Copy link
Contributor Author

rictic commented Oct 25, 2016

Files renamed, also deleted some out of date code. PTAL!

usergenic
usergenic approved these changes Oct 25, 2016
View reviewed changes
Copy link

@usergenic usergenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rictic rictic merged commit 11c004a into master Oct 25, 2016
@rictic
Copy link
Contributor Author

rictic commented Oct 25, 2016

Thanks for the review!

@rictic rictic deleted the consistent-name branch October 25, 2016 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usergenic usergenic usergenic approved these changes

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees

@justinfagnani justinfagnani

@TimvdLippe TimvdLippe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rictic @usergenic @TimvdLippe @justinfagnani