Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LitElement build #1289

Merged
merged 1 commit into from Sep 21, 2020
Merged

Fix LitElement build #1289

merged 1 commit into from Sep 21, 2020

Conversation

sorvell
Copy link
Member

@sorvell sorvell commented Sep 19, 2020

Fixes build for individual decorators.

Fixes build for individual decorators.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2020

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +15% (-5.70ms - +20.52ms)
    this-change vs tip-of-tree

render

  • lit-element-stub1: unsure 🔍 -3% - +2% (-0.73ms - +0.57ms)
    this-change vs tip-of-tree
  • lit-html-kitchen-sink: unsure 🔍 -31% - +94% (-5.65ms - +17.16ms)
    this-change vs tip-of-tree

update

  • lit-html-kitchen-sink: unsure 🔍 -10% - +32% (-5.46ms - +17.59ms)
    this-change vs tip-of-tree

Results

lit-element-stub1
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
24.63ms - 25.06ms-unsure 🔍
-3% - +2%
-0.73ms - +0.57ms
faster ✔
22% - 24%
6.93ms - 7.59ms
tip-of-tree
tip-of-tree
24.32ms - 25.54msunsure 🔍
-2% - +3%
-0.57ms - +0.73ms
-faster ✔
20% - 24%
6.51ms - 7.84ms
previous-release
previous-release
31.85ms - 32.36msslower ❌
28% - 31%
6.93ms - 7.59ms
slower ❌
25% - 32%
6.51ms - 7.84ms
-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.58ms - 35.36ms-unsure 🔍
-31% - +94%
-5.65ms - +17.16ms
faster ✔
3% - 66%
1.11ms - 24.00ms
tip-of-tree
tip-of-tree
17.57ms - 18.86msunsure 🔍
-60% - +12%
-17.16ms - +5.65ms
-faster ✔
48% - 52%
17.01ms - 19.60ms
previous-release
previous-release
35.40ms - 37.64msunsure 🔍
-20% - +125%
+1.11ms - +24.00ms
slower ❌
91% - 110%
17.01ms - 19.60ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
48.74ms - 71.74ms-unsure 🔍
-10% - +32%
-5.46ms - +17.59ms
faster ✔
15% - 42%
12.82ms - 35.97ms
tip-of-tree
tip-of-tree
53.44ms - 54.91msunsure 🔍
-27% - +7%
-17.59ms - +5.46ms
-faster ✔
35% - 37%
28.97ms - 31.95ms
previous-release
previous-release
83.33ms - 85.93msslower ❌
14% - 67%
12.82ms - 35.97ms
slower ❌
53% - 59%
28.97ms - 31.95ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
130.59ms - 156.70ms-unsure 🔍
-4% - +15%
-5.70ms - +20.52ms
faster ✔
8% - 23%
12.84ms - 39.26ms
tip-of-tree
tip-of-tree
135.01ms - 137.46msunsure 🔍
-14% - +4%
-20.52ms - +5.70ms
-faster ✔
19% - 21%
31.10ms - 35.82ms
previous-release
previous-release
167.68ms - 171.71msslower ❌
7% - 29%
12.84ms - 39.26ms
slower ❌
23% - 26%
31.10ms - 35.82ms
-

tachometer-reporter-action v2 for Benchmarks

@sorvell sorvell merged commit 18ab2f9 into lit-next Sep 21, 2020
@sorvell sorvell deleted the lit-next-fix-lit-element-build branch September 21, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants