tests should be mostly async #42

rafaelw opened this Issue Jan 16, 2014 · 2 comments


None yet
2 participants

rafaelw commented Jan 16, 2014

especially for Object.observe, async is the normal case (not forced deliver)

@rafaelw rafaelw added a commit that referenced this issue Jan 16, 2014

@rafaelw rafaelw ensure that observedSet resets observed objects after changes
this was a pretty major oversight on my part, and unfortunately, the tests are structure such that the "organic" callback of Object.observe is never depended upon.

What really needs to be done here is to make most of the tests be async using the then() pattern, but this bug is blocking polymer release, so I'm going to do that work in a follow-on patch.


Review URL: https://codereview.appspot.com/53490043

rafaelw was assigned by jmesserly Aug 7, 2014


jmesserly commented Aug 7, 2014

Happy to help with this too ... I'm guessing similar refactoring here as was done to the template binding tests?


jmesserly commented Aug 7, 2014

.... although presumably some (fraction of?) tests should stay using .deliver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment