tests should be mostly async #42

Open
rafaelw opened this Issue Jan 16, 2014 · 2 comments

Comments

Projects
None yet
2 participants
Member

rafaelw commented Jan 16, 2014

especially for Object.observe, async is the normal case (not forced deliver)

@rafaelw rafaelw added a commit that referenced this issue Jan 16, 2014

@rafaelw rafaelw ensure that observedSet resets observed objects after changes
this was a pretty major oversight on my part, and unfortunately, the tests are structure such that the "organic" callback of Object.observe is never depended upon.

What really needs to be done here is to make most of the tests be async using the then() pattern, but this bug is blocking polymer release, so I'm going to do that work in a follow-on patch.

#42
R=arv
BUG=

Review URL: https://codereview.appspot.com/53490043
0152d54

rafaelw was assigned by jmesserly Aug 7, 2014

Contributor

jmesserly commented Aug 7, 2014

Happy to help with this too ... I'm guessing similar refactoring here as was done to the template binding tests?

Contributor

jmesserly commented Aug 7, 2014

.... although presumably some (fraction of?) tests should stay using .deliver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment