This repository has been archived by the owner on May 1, 2019. It is now read-only.
properly set sourceRange and astNode on inline documents #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rictic
approved these changes
Feb 23, 2017
src/model/document.ts
Outdated
| // not have to be set awkwardly after the fact. | ||
| sourceRange: SourceRange|undefined = undefined; | ||
| astNode: dom5.Node|undefined = undefined; | ||
| ; |
src/test/analyzer_test.ts
Outdated
| const jsDoc = jsDocs.values().next().value; | ||
| assert.deepEqual(jsDoc.sourceRange, { | ||
| file: 'static/inline-documents/inline-documents.html', | ||
| start: {line: 3, column: 2}, |
There was a problem hiding this comment.
Use the CodeUnderliner rather than doing equality checking against source range
src/test/analyzer_test.ts
Outdated
| assert.equal(cssDocs.size, 1); | ||
| const cssDoc = cssDocs.values().next().value; | ||
| assert.deepEqual(cssDoc.sourceRange, { | ||
| file: 'static/inline-documents/inline-documents.html', |
src/test/analyzer_test.ts
Outdated
| }); | ||
| assert.isObject(jsDoc.astNode); | ||
| assert.equal(jsDoc.astNode!.tagName, 'script'); | ||
| assert.equal(jsDoc.astNode!.parentNode!.tagName, 'head'); |
There was a problem hiding this comment.
Why the assertion on the parent node?
There was a problem hiding this comment.
Chose it as a simple proxy for checking that the astNode was accurate. But having worked with the analyzer more now I feel we can assume that if the astNode is set it is accurate (at least in a larger analyzer test like this). So I'll back this out.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceRangeandastNodeon inlined documents./cc @rictic @justinfagnani