Source map support #12

Open
theefer opened this Issue Feb 17, 2014 · 24 comments

Comments

Projects
None yet
@theefer

theefer commented Feb 17, 2014

Are there any plans to support source maps in Vulcanize? Like any other transformation tool, it'd be really valuable to be able to trace code back to the original source.

I'm not aware of any other tool creating source maps for HTML yet (as opposed to the usual CSS/JS), so the spec might need some adapting in terms of how the source map is referenced from a comment at the end of the generated source file.

@azakus

This comment has been minimized.

Show comment
Hide comment
@azakus

azakus Feb 24, 2014

Member

I'll keep this in mind with the refactor I'm doing in #13

I don't believe any browser is capable of understanding anything like an HTML sourcemap at the moment, but I'll evaluate as I go.

Member

azakus commented Feb 24, 2014

I'll keep this in mind with the refactor I'm doing in #13

I don't believe any browser is capable of understanding anything like an HTML sourcemap at the moment, but I'll evaluate as I go.

@azakus azakus self-assigned this Aug 7, 2014

@pope

This comment has been minimized.

Show comment
Hide comment
@pope

pope Aug 18, 2014

Would it be fair to say that if you placed your JS in external files that source maps would then be quite handy?

pope commented Aug 18, 2014

Would it be fair to say that if you placed your JS in external files that source maps would then be quite handy?

@theefer

This comment has been minimized.

Show comment
Hide comment
@theefer

theefer Aug 18, 2014

Same for CSS too I guess.

theefer commented Aug 18, 2014

Same for CSS too I guess.

@williamcodes

This comment has been minimized.

Show comment
Hide comment
@williamcodes

williamcodes Mar 3, 2015

+1 to this feature request

+1 to this feature request

@phreaknation

This comment has been minimized.

Show comment
Hide comment

+1

@zeitiger

This comment has been minimized.

Show comment
Hide comment

+1

@NamTThai

This comment has been minimized.

Show comment
Hide comment
@NamTThai

NamTThai Sep 1, 2015

+1 for feature request

NamTThai commented Sep 1, 2015

+1 for feature request

@danbeam

This comment has been minimized.

Show comment
Hide comment
@danbeam

danbeam Oct 21, 2015

+1 what's the status on this? would it likely entail a lot of work?

for things like Chrome's downloads or settings page, we'd probably want some way of reversing a trace back to original code line number as we get a lot of bugs in the wild that are hard to reproduce ourselves

danbeam commented Oct 21, 2015

+1 what's the status on this? would it likely entail a lot of work?

for things like Chrome's downloads or settings page, we'd probably want some way of reversing a trace back to original code line number as we get a lot of bugs in the wild that are hard to reproduce ourselves

@ghzmdr

This comment has been minimized.

Show comment
Hide comment

ghzmdr commented Oct 22, 2015

@indolering

This comment has been minimized.

Show comment
Hide comment
@indolering

indolering Dec 17, 2015

+1 tracking bugs in production is a PITA without sourcemaps.

+1 tracking bugs in production is a PITA without sourcemaps.

@indolering

This comment has been minimized.

Show comment
Hide comment
@indolering

indolering Dec 19, 2015

I don't believe any browser is capable of understanding anything like an HTML sourcemap at the moment, but I'll evaluate as I go.

@azakus This is a datapoint of one, but the size of my elements are 10:1 JS:HTML/CSS. When used in conjunction with CSP ....

I don't believe any browser is capable of understanding anything like an HTML sourcemap at the moment, but I'll evaluate as I go.

@azakus This is a datapoint of one, but the size of my elements are 10:1 JS:HTML/CSS. When used in conjunction with CSP ....

@indolering

This comment has been minimized.

Show comment
Hide comment
@indolering

indolering Jan 14, 2016

I've officially run into two bugs in production that I can't reproduce without running it through Vulcanize/Polybuild. The lack of source maps makes Polymer unsuitable for production use and this ticket should at least be prioritized.

I've officially run into two bugs in production that I can't reproduce without running it through Vulcanize/Polybuild. The lack of source maps makes Polymer unsuitable for production use and this ticket should at least be prioritized.

@robdodson

This comment has been minimized.

Show comment
Hide comment
@robdodson

robdodson Jan 14, 2016

Contributor

@indolering are you combining vulcanize with any html/css minifiers? they can often cause subtle bugs

Contributor

robdodson commented Jan 14, 2016

@indolering are you combining vulcanize with any html/css minifiers? they can often cause subtle bugs

@indolering

This comment has been minimized.

Show comment
Hide comment
@indolering

indolering Jan 18, 2016

@robdodson No, but I ran into a bug in Polybuild's CSS minifier too.

@robdodson No, but I ran into a bug in Polybuild's CSS minifier too.

@robdodson

This comment has been minimized.

Show comment
Hide comment
@robdodson

robdodson Jan 19, 2016

Contributor

In Polymer Starter Kit we had issues with polybuild and switched back to using Vuclanize by itself. Have you tried that?

Contributor

robdodson commented Jan 19, 2016

In Polymer Starter Kit we had issues with polybuild and switched back to using Vuclanize by itself. Have you tried that?

@zeitiger

This comment has been minimized.

Show comment
Hide comment
@zeitiger

zeitiger Jan 19, 2016

I combine only babel 5.x and than vulcanize together

I combine only babel 5.x and than vulcanize together

@indolering

This comment has been minimized.

Show comment
Hide comment
@indolering

indolering Jan 20, 2016

@robdodson Turning CSP back on fixed it, I had manually disabled it. I'm just afraid that something is going to break in the future and I will be unable to troubleshoot it properly. I can't risk releasing something into production that I might have to pull because I can't troubleshoot what's wrong with the vulcanize or the minifier.

@robdodson Turning CSP back on fixed it, I had manually disabled it. I'm just afraid that something is going to break in the future and I will be unable to troubleshoot it properly. I can't risk releasing something into production that I might have to pull because I can't troubleshoot what's wrong with the vulcanize or the minifier.

@Qvatra

This comment has been minimized.

Show comment
Hide comment

@Qvatra Qvatra referenced this issue in googlearchive/polybuild Jan 21, 2016

Open

Support of source-maps #26

@difosfor

This comment has been minimized.

Show comment
Hide comment

+1

@LuisTJap

This comment has been minimized.

Show comment
Hide comment

LuisTJap commented Jun 7, 2016

+1

@kito99

This comment has been minimized.

Show comment
Hide comment

kito99 commented Jul 20, 2016

+1

@ronnyroeller

This comment has been minimized.

Show comment
Hide comment

+1

@maxiplay

This comment has been minimized.

Show comment
Hide comment

+1

@indolering

This comment has been minimized.

Show comment
Hide comment
@indolering

indolering Sep 1, 2016

Please stop spamming my notification feed with +1 posts, use an emoticon reaction to signal your support and the star button to track it.

Please stop spamming my notification feed with +1 posts, use an emoticon reaction to signal your support and the star button to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment