Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: Polymer/polymer
Choose a Base Repository
Polymer/polymer
100000001/polymer
11111000000/biopolymer
Acidburn0zzz/polymer
Artyom4D/polymer
BarkocziRoland/polymer
BasilLade/polymer
BluPerf/polymer
BrianSipple/polymer
BushiNoTamashiiKen/polymer
CNXTEoEorg/polymer
ColleenKeegan/polymer
Durdona/polymer
EmmaGrassi/polymer
GCPBigData/polymer
GeneralElectric/polymer
ISvengali/polymer
Jbossalini/polymer
Kazzje/polymer
ManufactureDistrict/polymer
MedRedha/polymer
Nitansh/polymer
PolymerEl/polymer
RandomStuffs22/polymer
STRML/polymer
Sagar2366/polymer
SaidTayebi/polymer
Satya-AK/polymer
Shipow/polymer
TimvdLippe/polymer
Troland/polymer
Vintharas/polymer
WahsonLeung/polymer
Waseem-Abbas/polymer
Yokubee/polymer
ZheFeng/polymer
aaronteng922/polymer
adam-singer/polymer
adamdbradley/polymer
aizatyahyaa/polymer
alexcheng1982/polymer
alinz/polymer
allmywant/polymer
andylou/polymer
andypham/polymer
anujsrc/polymer
arthurevans/polymer
arv/toolkit
astraadria4ari/polymer
austinvernsonger/polymer
awesome/polymer
bantana/polymer
belm/polymer
beomjae/polymer
betop/polymer
bryansattler/polymer
casualuser/toolkit
cbarbsintokyo/polymer
chenxinshi/polymer
cletusw/polymer
clovisdasilvaneto/polymer-1
cocus-es/polymer
contactlab/polymer
cssgist/polymer
cymen/polymer
d1manson/polymer
davgit/polymer
deepak1556/polymer
dekaralos/polymer
devcrust/polymer
devnaruka/polymer
dewott-technologies/polymer
dmorosinotto/polymer
dontuse/polymer
dshamaeli/polymer
dujuanxian/polymer
edisplay/polymer
ega1979/polymer
empoalp/polymer
en4ce/polymer
exlerdesigns/polymer
feskong/polymer
fjsnogueira/polymer
fnakstad/polymer
gerardoacuna/polymer
girliemac/polymer
happyspace/polymer
henrylee2cn/polymer
hutaoer/polymer
iArnaud/polymer
iLotus/polymer
igutnikdev/polymer
ilyych/polymer
imaginationagents1/polymer
inigo0178/polymer
iulyus/polymer
jacklovepdf/polymer
jamesalley/polymer
jamiepg1/polymer
jaredwilli/polymer
jarvys/polymer
jayvansantos/polymer
jessepinuelas/polymer
jiangshide/polymer
jiazil/polymer
jjpsos/polymer
jmesserly/polymer
joaogbm/polymer
jongrover/polymer
jpaezsa/polymer
just-me-cy/polymer
kanasite/polymer
kelonye/polymer
kotiya/polymer
kublaj/polymer
labriola/polymer
lanphan/polymer
letsila/polymer
lholmquist/polymer
liqingzhu/polymer
lisongx/polymer
lonjoy/polymer
lovefawn/polymer
m4b/polymer
markserbol/polymer
martabel/polymer
mauricionr/polymer
mbleigh/polymer
mcanthony/polymer
mdarif/polymer
miamarti/polymer
michaelhweb/polymer
mimundome/polymer
minhsong/polymer
mis8680/polymer
mixed/polymer
mk199/polymer
mmnmm/polymer
montazze/polymer
naqi324/polymer
naysumyat/polymer
nichealpham/polymer
nvdnkpr/polymer
nxbdi/polymer
onesfreedom/polymer
oscarenas/polymer
parikhutsav/polymer
pranderson/polymer
prasadsambari/polymer
primaapriansyah/toolkit
ptrpovtyu/polymer
rafaelducati/polymer
rakesh-mohanta/polymer
randyamiel/polymer
randylien/polymer
raymonlee/polymer
redfordtsai/polymer
rishitc/polymer
rivkesse/polymer
rjnpnigrhi/polymer
royyu2898/polymer
salvoravida/polymer
sanyaade-teachings/polymer
seasu/polymer
sergiolimajr/polymer
shockwavemk/polymer
simonbaker/polymer
sorvell/toolkit
soulhakr/polymer
srinarasi/polymer
startsomewhere/polymer
svencent/polymer
sxtxixtxcxh/polymer
sylphdesign/polymer
tcorral/polymer
tedyhy/polymer
teruhisa/polymer
thegrowthland/polymer
tibbon/polymer
toolkitchen/toolkit
trevenen/polymer
uapui-dev/polymer
uloga/polymer
unixcrh/polymer
varunjha089/polymer
web-padawan/polymer
woerwin/polymer
xiaozhen1900/polymer
xiaxiazhu/polymer
xtidt/polymer
xuanvu/polymer
xzymol123/polymer
yangjae/polymer
yanguanglan/polymer
yold-io/polymer
yuebin/polymer
yuinchien/toolkit
zhangchunsheng/polymer
zhangjianshe/polymer
zxmLoveLife/polymer
Nothing to show
base: d2c0bdb5b2c5^
head repository: Polymer/polymer
Choose a Head Repository
Polymer/polymer
100000001/polymer
11111000000/biopolymer
Acidburn0zzz/polymer
Artyom4D/polymer
BarkocziRoland/polymer
BasilLade/polymer
BluPerf/polymer
BrianSipple/polymer
BushiNoTamashiiKen/polymer
CNXTEoEorg/polymer
ColleenKeegan/polymer
Durdona/polymer
EmmaGrassi/polymer
GCPBigData/polymer
GeneralElectric/polymer
ISvengali/polymer
Jbossalini/polymer
Kazzje/polymer
ManufactureDistrict/polymer
MedRedha/polymer
Nitansh/polymer
PolymerEl/polymer
RandomStuffs22/polymer
STRML/polymer
Sagar2366/polymer
SaidTayebi/polymer
Satya-AK/polymer
Shipow/polymer
TimvdLippe/polymer
Troland/polymer
Vintharas/polymer
WahsonLeung/polymer
Waseem-Abbas/polymer
Yokubee/polymer
ZheFeng/polymer
aaronteng922/polymer
adam-singer/polymer
adamdbradley/polymer
aizatyahyaa/polymer
alexcheng1982/polymer
alinz/polymer
allmywant/polymer
andylou/polymer
andypham/polymer
anujsrc/polymer
arthurevans/polymer
arv/toolkit
astraadria4ari/polymer
austinvernsonger/polymer
awesome/polymer
bantana/polymer
belm/polymer
beomjae/polymer
betop/polymer
bryansattler/polymer
casualuser/toolkit
cbarbsintokyo/polymer
chenxinshi/polymer
cletusw/polymer
clovisdasilvaneto/polymer-1
cocus-es/polymer
contactlab/polymer
cssgist/polymer
cymen/polymer
d1manson/polymer
davgit/polymer
deepak1556/polymer
dekaralos/polymer
devcrust/polymer
devnaruka/polymer
dewott-technologies/polymer
dmorosinotto/polymer
dontuse/polymer
dshamaeli/polymer
dujuanxian/polymer
edisplay/polymer
ega1979/polymer
empoalp/polymer
en4ce/polymer
exlerdesigns/polymer
feskong/polymer
fjsnogueira/polymer
fnakstad/polymer
gerardoacuna/polymer
girliemac/polymer
happyspace/polymer
henrylee2cn/polymer
hutaoer/polymer
iArnaud/polymer
iLotus/polymer
igutnikdev/polymer
ilyych/polymer
imaginationagents1/polymer
inigo0178/polymer
iulyus/polymer
jacklovepdf/polymer
jamesalley/polymer
jamiepg1/polymer
jaredwilli/polymer
jarvys/polymer
jayvansantos/polymer
jessepinuelas/polymer
jiangshide/polymer
jiazil/polymer
jjpsos/polymer
jmesserly/polymer
joaogbm/polymer
jongrover/polymer
jpaezsa/polymer
just-me-cy/polymer
kanasite/polymer
kelonye/polymer
kotiya/polymer
kublaj/polymer
labriola/polymer
lanphan/polymer
letsila/polymer
lholmquist/polymer
liqingzhu/polymer
lisongx/polymer
lonjoy/polymer
lovefawn/polymer
m4b/polymer
markserbol/polymer
martabel/polymer
mauricionr/polymer
mbleigh/polymer
mcanthony/polymer
mdarif/polymer
miamarti/polymer
michaelhweb/polymer
mimundome/polymer
minhsong/polymer
mis8680/polymer
mixed/polymer
mk199/polymer
mmnmm/polymer
montazze/polymer
naqi324/polymer
naysumyat/polymer
nichealpham/polymer
nvdnkpr/polymer
nxbdi/polymer
onesfreedom/polymer
oscarenas/polymer
parikhutsav/polymer
pranderson/polymer
prasadsambari/polymer
primaapriansyah/toolkit
ptrpovtyu/polymer
rafaelducati/polymer
rakesh-mohanta/polymer
randyamiel/polymer
randylien/polymer
raymonlee/polymer
redfordtsai/polymer
rishitc/polymer
rivkesse/polymer
rjnpnigrhi/polymer
royyu2898/polymer
salvoravida/polymer
sanyaade-teachings/polymer
seasu/polymer
sergiolimajr/polymer
shockwavemk/polymer
simonbaker/polymer
sorvell/toolkit
soulhakr/polymer
srinarasi/polymer
startsomewhere/polymer
svencent/polymer
sxtxixtxcxh/polymer
sylphdesign/polymer
tcorral/polymer
tedyhy/polymer
teruhisa/polymer
thegrowthland/polymer
tibbon/polymer
toolkitchen/toolkit
trevenen/polymer
uapui-dev/polymer
uloga/polymer
unixcrh/polymer
varunjha089/polymer
web-padawan/polymer
woerwin/polymer
xiaozhen1900/polymer
xiaxiazhu/polymer
xtidt/polymer
xuanvu/polymer
xzymol123/polymer
yangjae/polymer
yanguanglan/polymer
yold-io/polymer
yuebin/polymer
yuinchien/toolkit
zhangchunsheng/polymer
zhangjianshe/polymer
zxmLoveLife/polymer
Nothing to show
compare: 2198d4a91db7
  • 8 commits
  • 27 files changed
  • 1 commit comment
  • 1 contributor
@@ -1,13 +0,0 @@
<!--
@license
Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<link rel="import" href="src/features/bind.html">
<link rel="import" href="src/features/annotations-bind.html">
<link rel="import" href="src/features/computed.html">
<link rel="import" href="src/features/bind-effects.html">
@@ -0,0 +1,75 @@
<!--
@license
Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<link rel="import" href="src/polymer.html">
<link rel="import" href="src/features/log.html">
<link rel="import" href="src/features/constructor.html">
<link rel="import" href="src/features/extends.html">
<link rel="import" href="src/features/mixins.html">
<link rel="import" href="src/features/published.html">
<link rel="import" href="src/features/attributes.html">
<link rel="import" href="src/features/template.html">
<link rel="import" href="src/features/content.html">
<link rel="import" href="src/features/annotations.html">
<link rel="import" href="src/features/annotations-nodes.html">
<link rel="import" href="src/features/events.html">
<link rel="import" href="src/features/keys.html">
<link rel="import" href="src/features/annotations-events.html">
<link rel="import" href="src/features/utils.html">
<link rel="import" href="src/features/ready.html">

<link rel="import" href="src/layout.html">

<script>
// TODO(sjmiles): hack
Base.originalInitFeatures = Base.initFeatures;
Base.addFeature({
initFeatures: function() {
// TODO(sjmiles): hack to make sure this feature goes last
this.originalInitFeatures(this);
this.features();
},
features: function() {
this.defaultFeatures();
},
defaultFeatures: function() {
if (this._useContent) {
this.poolContent();
}
if (this._template) {
this.stampTemplate();
this._marshalNodeReferences();
this._marshalAnnotatedNodes();
this._setupAnnotatedListeners();
if (this._setupBindListeners) {
this._setupBindListeners();
}
}
this.listenListeners();
this.listenKeyPresses();
if (this._useContent) {
this.distributeContent();
}
this.takeAttributes();
}
});
Polymer.noFeatures = function() {
};
Polymer.defaultFeatures = Base.defaultFeatures;
</script>

@@ -0,0 +1,13 @@
<!--
@license
Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<link rel="import" href="src/data-features/bind.html">
<link rel="import" href="src/data-features/annotations-bind.html">
<link rel="import" href="src/data-features/computed.html">
<link rel="import" href="src/data-features/bind-effects.html">
@@ -7,65 +7,5 @@
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<link rel="import" href="src/polymer.html">
<link rel="import" href="src/features/log.html">
<link rel="import" href="src/features/published.html">
<link rel="import" href="src/features/attributes.html">
<link rel="import" href="src/features/template.html">
<link rel="import" href="src/features/content.html">
<link rel="import" href="src/features/annotations.html">
<link rel="import" href="src/features/annotations-nodes.html">
<link rel="import" href="src/features/events.html">
<link rel="import" href="src/features/keys.html">
<link rel="import" href="src/features/annotations-events.html">
<link rel="import" href="src/features/utils.html">
<link rel="import" href="src/features/layout.html">
<link rel="import" href="src/features/ready.html">

<script>
// TODO(sjmiles): hack
Base.originalInitFeatures = Base.initFeatures;
Base.addFeature({
initFeatures: function() {
// TODO(sjmiles): hack to make sure this feature goes last
this.originalInitFeatures(this);
this.features();
},
features: function() {
this.defaultFeatures();
},
defaultFeatures: function() {
if (this._useContent) {
this.poolContent();
}
if (this._template) {
this.stampTemplate();
this._marshalNodeReferences();
this._marshalAnnotatedNodes();
this._setupAnnotatedListeners();
if (this._setupBindListeners) {
this._setupBindListeners();
}
}
this.listenListeners();
this.listenKeyPresses();
if (this._useContent) {
this.distributeContent();
}
this.takeAttributes();
}
});
Polymer.noFeatures = function() {
};
Polymer.defaultFeatures = Base.defaultFeatures;
</script>

<link rel="import" href="polymer-core.html">
<link rel="import" href="polymer-data.html">
@@ -67,6 +67,7 @@
},
attachedCallback: function() {
this.isAttached = true;
// reserved for canonical behavior
this.attached();
},
@@ -76,6 +77,7 @@
},
detachedCallback: function() {
this.isAttached = false;
// reserved for canonical behavior
this.detached();
},
@@ -7,7 +7,7 @@
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<link rel="import" href="annotations.html">
<link rel="import" href="../features/annotations.html">

<script>
@@ -51,11 +51,11 @@
// per prototype
register: function(prototype) {
prototype._bindListeners = [];
prototype._createBindings();
},
_createBindings: function() {
this._bindListeners = [];
var fx$ = this._propertyEffects;
if (fx$) {
//console.group(this.name);
@@ -76,14 +76,13 @@
},
_sortPropertyEffects: function(a, b) {
switch (a.kind) {
case 'compute':
return b.kind === 'compute' ? 0 : -1;
case 'notify':
return b.kind === 'notify' ? 0 : 1;
default:
return 0;
if (a.kind === 'compute' || b.kind === 'notify') {
return -1;
}
if (a.kind === 'notify' || b.kind === 'compute') {
return 1;
}
return 0;
},
_buildEffect: function(property, fx) {
File renamed without changes.
File renamed without changes.
@@ -0,0 +1,76 @@
<!--
@license
Copyright (c) 2014 The Polymer Project Authors. All rights reserved.
This code may only be used under the BSD style license found at http://polymer.github.io/LICENSE.txt
The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
-->
<link rel="import" href="annotations.html">

<script>
/*
* Parses the annotations list created by `annotations` features to perform
* declarative desugaring.
*
* Depends on `annotations` feature and `bind` feature.
*
* Two tasks are supported:
*
* - nodes with 'id' are described in a virtual annotation list at
* registration time. This list is then concretized per instance.
*
* - Simple mustache expressions consisting of a single property name
* in a `textContent` context are bound using `bind` features
* `bindMethod`. In this mode, the bound method is constructed at
* registration time, so marshaling is done done via the concretized
* `_nodes` at every access.
*
* TODO(sjmiles): ph3ar general confusion between registration and
* instance time tasks. Is there a cleaner way to disambiguate?
*/
TemplateBind = {
// construct binding meta-data
_preprocessBindAnnotations: function(prototype, list) {
// create a virtual annotation list, must be concretized at instance time
prototype._nodes = [];
// process annotations that have been parsed from template
list.forEach(function(annotation) {
// where to find the node in the concretized list
var index = prototype._nodes.push(annotation) - 1;
// TODO(sjmiles): we need to support multi-bind, right now you only get
// one (not including kind === `id`)
annotation.bindings.forEach(function(binding) {
prototype._bindAnnotationBinding(binding, index);
});
});
},
// _nodes[index][<binding.name=>]{{binding.value}}
_bindAnnotationBinding: function(binding, index) {
// capture the node index
binding.index = index;
// discover top-level property (model) from path
var path = binding.value;
var i = path.indexOf('.');
// [name=]{{model[.subpath]}}
var model = (i >= 0) ? path.slice(0, i) : path;
// add 'annotation' binding effect for property 'model'
this.addPropertyEffect(model, 'annotation', binding);
}
// concretize `_nodes` map (annotation based)
marshalAnnotatedNodes: function(nodes, root) {
return nodes.map(function(a) {
return Template.findAnnotatedNode(root, a);
};
}
});
</script>

Showing you all comments on commits in this comparison.

@nevir

This comment has been minimized.

Copy link
Contributor

nevir commented on 993a2cc Dec 12, 2014

Wait, it mixes in asynchronously!?

You can’t perform that action at this time.