Skip to content

Loading…

Custom properties fail to resolve when an element is attached to an unknown shadowRoot #2078

Closed
sorvell opened this Issue · 0 comments

1 participant

@sorvell
Owner

Given an element added to an unknown shadowRoot like this:

var root = unknownHostElement.createShadowRoot();
root.appendChild(document.createElement('x-foo'));

An exception will occur due to the fact that it's assumed that the dom host of the x-foo element has a known styling api which can be interrogated. In this case the dom host of x-foo is not a Polymer element. We'll need to make the property resolver smarter about finding a styling host to avoid this problem and ensure that elements in unknown hosts are properly styled.

@sorvell sorvell self-assigned this
@sorvell sorvell added the p0 label
@sorvell sorvell closed this issue from a commit
@sorvell sorvell Fixes #2078: when computing custom style properties, make sure the st…
…yling scope is valid when the element is attached to a shadowRoot whose host is not a Polymer element.
fab2ed7
@sorvell sorvell closed this in fab2ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.