Skip to content

/polymer

Loading…

New issue

Polymer.dom can call some shady dom code when running shadow dom #2341

Closed
sorvell opened this Issue · 4 comments

Labels

p1

Milestone

No milestone

Assignee

@rictic rictic

2 participants

@sorvell @rictic
@sorvell
Owner
sorvell commented

For example, the dom mutation methods call shady dom code paths. Instead they should be routed to the native dom methods: appendChild, insertBefore, removeChild, replaceChild, cloneNode.

@sorvell sorvell added the p1 label
@sorvell sorvell self-assigned this
@sorvell
Owner
sorvell commented

NOTE: #2338 was submitted to correct this issue, but I think we should just branch these methods earlier instead.

@sorvell sorvell removed their assignment
@rictic rictic was assigned by sorvell
@sorvell
Owner
sorvell commented

@rictic Would you mind taking a look at my PR for this #2342 and testing it out. Feel free to merge it if it looks ok. Thanks!

@rictic
Owner
rictic commented

Running tests

@rictic
Owner
rictic commented

The tests that were failing before are passing now. I'll do a full run and merge this tonight if all's well.

@rictic rictic referenced this issue
Closed

Don't call shady dom method when using shadow dom #2338

@sorvell sorvell closed this issue from a commit
@sorvell sorvell Fixes #2341: branch Polymer.dom to use native dom methods under Shado… … 
…w DOM for: appendChild, insertBefore, removeChild, replaceChild, cloneNode.
 9b1f706
@sorvell sorvell closed this in 9b1f706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.