Skip to content

Consider adding temporarily cached path fixup for correctness #4227

Closed

Description

@kevinpschaaf

#4221 introduced a "temporary" cache for dirty checking sub-paths of objects, which is cleared at the end of the turn. The allows the removal of the 1.x Collection abstraction by just notifying index-based array paths, since it avoids index-based paths being cached indefinitely, where splices to the array can leave them invalid.

However, the temp cache is not necessarily sufficient to prevent invalid array paths, since a splice can happen during the same turn with pathological user code; we could introduce a "fixup" at _setProperty to clear or adjust the index of temporarily cached array paths if needed.

Activity

  1. self-assigned this
    on Dec 19, 2016
  2. TimvdLippe commented on Mar 16, 2018

    @TimvdLippe
    Contributor

    Yeah, so this "temporary" cache still exists 😂 @kevinpschaaf Is this something we still want to do or shall we close it as wontfix? From the original comment I don't understand it fully and it misses a JSBin.

  3. stale commented on Mar 13, 2020

    @stale

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  4. stale commented on Apr 17, 2022

    @stale

    This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions