You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consider adding temporarily cached path fixup for correctness #4227
#4221 introduced a "temporary" cache for dirty checking sub-paths of objects, which is cleared at the end of the turn. The allows the removal of the 1.x Collection abstraction by just notifying index-based array paths, since it avoids index-based paths being cached indefinitely, where splices to the array can leave them invalid.
However, the temp cache is not necessarily sufficient to prevent invalid array paths, since a splice can happen during the same turn with pathological user code; we could introduce a "fixup" at _setProperty to clear or adjust the index of temporarily cached array paths if needed.
Yeah, so this "temporary" cache still exists 😂 @kevinpschaaf Is this something we still want to do or shall we close it as wontfix? From the original comment I don't understand it fully and it misses a JSBin.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!
Activity
TimvdLippe commentedon Mar 16, 2018
Yeah, so this "temporary" cache still exists 😂 @kevinpschaaf Is this something we still want to do or shall we close it as wontfix? From the original comment I don't understand it fully and it misses a JSBin.
stale commentedon Mar 13, 2020
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
stale commentedon Apr 17, 2022
This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!