New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert browser-side code to typescript #635

Merged
merged 51 commits into from Oct 13, 2017

Conversation

Projects
None yet
3 participants
@rictic
Contributor

rictic commented Oct 11, 2017

  • CHANGELOG.md not updated, this is a noop change

This brings it into the fold of maintainability.

I did it as tiny changes that separated out renaming from converting in the hopes that this would help github with diffing. It did not. Deliberately losing renaming metadata is one of git's original sins.

@rictic rictic requested a review from usergenic Oct 11, 2017

@googlebot googlebot added the cla: yes label Oct 11, 2017

@rictic

This comment has been minimized.

Show comment
Hide comment
@rictic

rictic Oct 11, 2017

Contributor

(because the mini-commits don't seem to add a lot I'll probably squash this down to a single commit when merging)

Contributor

rictic commented Oct 11, 2017

(because the mini-commits don't seem to add a lot I'll probably squash this down to a single commit when merging)

@usergenic

This looks great. I also tried running tests in the node-based basic-polymer-element project with this version of wct-browser-legacy and it appeared to work just fine.

LGTM!

Next up a11ySuite.js

@rictic rictic merged commit ed21e16 into master Oct 13, 2017

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rictic rictic deleted the browser-ts branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment