New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'KeyboardEvent.keyIdentifier' is deprecated warning in Chrome #53
Comments
I'm going to send a PR to fix that warning. |
I'm afraid it would be a breaking change as other browsers don't support |
@valdrinkoshi thoughts on falling back to key Identifier if key is not supported? |
@samccone that's already happening, see https://github.com/PolymerElements/iron-a11y-keys-behavior/blob/master/iron-a11y-keys-behavior.html#L178
|
correct, but switching the order of the fallback so that |
Unfortunately the warning gets displayed anyways if for example you hit "?" (shift + / key in US keyboard). I think that if (keyEvent.key) {
return transformKey(keyEvent.key, noSpecialChars);
}
if (keyEvent.detail && keyEvent.detail.key) {
return transformKey(keyEvent.detail.key, noSpecialChars);
}
return transformKeyIdentifier(keyEvent.keyIdentifier) ||
transformKeyCode(keyEvent.keyCode) || ''; I'll take care of that (there are some tests to be fixed) |
Description
This warning is caused by line 182:
Seems that this should be removed.
The text was updated successfully, but these errors were encountered: