A few things required to show the deprecation warning #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
changed the title
--iron-component-page-header-panel
blasten
force-pushed
the
paper-header-mixin
branch
from
9d611b6
to
76f951f
Compare
|
Can you document this mixin in the #Styling section, pls? Also uhhh (and I'm sorry this will sound annoying) are we worried whether just randomly starting to distribute content is a breaking change? |
blasten
force-pushed
the
paper-header-mixin
branch
from
96c4d6c
to
59d0397
Compare
|
@notwaldorf I actually didn't need the mixin! I have specified a selector for the distribution point to address your concern. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.