fixes issue #23: cdn.rawgit.com-hosted files will never change after … #25

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

…first load

the code uses the github api to fetch the list of available tags and uses the first one in the list.
if there are no tags it will fall back to using the master branch.

fixes issue #23: cdn.rawgit.com-hosted files will never change after …
…first load

the code uses the github api to fetch the list of available tags and uses the first one in the list.
if there are no tags it will fall back to using the master branch.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

I signed it :-)

CLAs look good, thanks!

ref: issue #23

Contributor

mbleigh commented May 20, 2015

This solution is somewhat problematic in that the GitHub API is extremely rate-limited for unauthenticated public requests. If someone were browsing a large number of elements they'd quickly hit the ceiling and things would start breaking.

I've been trying to come up with a solution to this myself, haven't landed on something I love yet other than hosting some kind of API proxy to get around the rate-limit issue.

hmm, yes, I see there's a limit of 60 requests per hour per IP for unauthenticated requests. This can be read as 1 request per minute. Casual browsing might just get away with it. But more heavy use will fall afoul. I'm not sure what else we can do though.

(ref: https://developer.github.com/v3/#rate-limiting)

Contributor

cdata commented Feb 3, 2016

Thank you for your contribution! I'm going to close this PR for now, since it doesn't have a corresponding issue and / or corresponding tests. Please consult our contribution guidelines for help on filing issues and opening PRs in the future!

@cdata cdata closed this Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment