Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fixes issue #23: cdn.rawgit.com-hosted files will never change after … #25
Conversation
googlebot
commented
May 20, 2015
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). Once you've signed, please reply here (e.g.
|
diddledan
commented
May 20, 2015
|
I signed it :-) |
googlebot
commented
May 20, 2015
|
CLAs look good, thanks! |
diddledan
commented
May 20, 2015
|
ref: issue #23 |
diddledan
referenced this pull request
May 20, 2015
Closed
cdn.rawgit.com-hosted files will never change after first load #23
|
This solution is somewhat problematic in that the GitHub API is extremely rate-limited for unauthenticated public requests. If someone were browsing a large number of elements they'd quickly hit the ceiling and things would start breaking. I've been trying to come up with a solution to this myself, haven't landed on something I love yet other than hosting some kind of API proxy to get around the rate-limit issue. |
diddledan
commented
May 20, 2015
|
hmm, yes, I see there's a limit of 60 requests per hour per IP for unauthenticated requests. This can be read as 1 request per minute. Casual browsing might just get away with it. But more heavy use will fall afoul. I'm not sure what else we can do though. |
|
Thank you for your contribution! I'm going to close this PR for now, since it doesn't have a corresponding issue and / or corresponding tests. Please consult our contribution guidelines for help on filing issues and opening PRs in the future! |
diddledan commentedMay 20, 2015
…first load
the code uses the github api to fetch the list of available tags and uses the first one in the list.
if there are no tags it will fall back to using the master branch.