This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Fix confusion between paths and urls #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@ankon Can you rebase these changes? |
There is other code assuming it could append things to root, and/or that root has a parent that is not '.', so we need this to be a proper absolute path.
There was quite some confusion here in terms of what is a url, and what is a path.
shared.html is in a temporary directory, and the existing resolver doesn't understand that (intentionally). For vulcanizing shared.html we therefore need to use a resolver that knows about shared.html, and that can correctly return it.
|
Sure, no problem :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #5, and fixes some additional issues.
All these changes became needed for https://github.com/Collaborne/gulp-web-component-shards to work "nicely".