Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode tracks asynchronously #39

Closed
Feld0 opened this Issue Dec 18, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@Feld0
Copy link
Contributor

commented Dec 18, 2015

Tracks are currently encoded synchronously within the HTTP request that sends them to the server. There are a few downfalls to this:

  • if the track takes longer to transcode than the request timeout, the track upload fails (happened the other day)
  • if the upload fails, the uploaded file is lost, which makes it hard to fix this for a user without requesting the file from them out-of-band #poorUX
  • the current implementation only transcodes one file at a time, which takes much longer than it needs to (these can be done in parallel)

All of this can be resolved by implementing an asynchronous encoding queue.

@Feld0 Feld0 added the bug label Dec 18, 2015

@Feld0 Feld0 self-assigned this Dec 18, 2015

@Feld0 Feld0 added the in progress label Dec 18, 2015

@Feld0

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2015

The implementation is complete but for this to actually work asynchronously, Pony.fm needs to be deployed with queue workers (production is currently using the synchronous queue driver).

Since the deployment process will have to restart these workers, I'm taking the opportunity to clean up and ansiblize Pony.fm's production infrastructure.

Feld0 added a commit that referenced this issue Dec 18, 2015

Feld0 added a commit that referenced this issue Dec 18, 2015

@Feld0

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2015

This is now running in production with real queue workers!

@Feld0 Feld0 closed this Dec 20, 2015

@Feld0 Feld0 removed the in progress label Dec 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.