Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2 - Barebones app created #6

Merged
merged 3 commits into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@steaward
Copy link
Contributor

commented Nov 3, 2018

Hey guys,

So I followed the guide @ https://code.visualstudio.com/docs/extensions/example-hello-world

In order to test the functionality of this app, you need to open codewalker > hit f5 > enter the command prompt: ctrl + shift + p > type in a command (In this case it's simply 'hello world' ). In order to change this command, we edit a package.json file, seen here
-- We can change this stuff asap.

Another thing to note. I usually run a Linux environment, with VSCode v 1.28.x
1.28 MUST be installed to debug the extension (any platform). So make sure that is the case.
However, my Linux machine was unable to properly open 'Extension Development' mode when debugging the extension. So I had to switch over to my Windows machine.

@steaward steaward changed the title Issue #2 - Barebones app created Issue:#2 - Barebones app created Nov 3, 2018

@steaward steaward changed the title Issue:#2 - Barebones app created #2 - Barebones app created Nov 3, 2018

@steaward steaward changed the title #2 - Barebones app created Issue #2 - Barebones app created Nov 3, 2018

@@ -0,0 +1,7 @@
{
// See http://go.microsoft.com/fwlink/?LinkId=827846
// for the documentation about the extensions.json format

This comment has been minimized.

Copy link
@humphd

humphd Nov 4, 2018

JSON can't have comments, should remove these.

@steaward

This comment has been minimized.

Copy link
Contributor Author

commented Nov 5, 2018

@PopeSpaceous removed those comments! Do you mind taking a look again?

"compilerOptions": {
"module": "commonjs",
"target": "es6",
"checkJs": true, /* Typecheck .js files. */

This comment has been minimized.

Copy link
@PopeSpaceous

PopeSpaceous Nov 5, 2018

Owner

Some more comments here to remove.

Maybe do Another Check through the file for more.
Thanks @steaward

This comment has been minimized.

Copy link
@Michael-Overall

Michael-Overall Nov 5, 2018

Collaborator

These were actually auto-generated by the Yo Code extension generator used by the tutorial. If we want to follow @humphd 's suggestion of keeping json files free of comments, this can be removed...

@Michael-Overall

This comment has been minimized.

Copy link
Collaborator

commented Nov 5, 2018

Looking at the file structure, I believe @steaward went for the JavaScript option when generating the startup project (other option was TypeScript). Am I correct in thinking this?

Aside from that question, the Hello world extension appears to be operating as per the tutorial specifications.

@PopeSpaceous

This comment has been minimized.

Copy link
Owner

commented Nov 5, 2018

@steaward Would you be able to put your testing Instructions in the Readme.md?
Thanks

@PopeSpaceous PopeSpaceous merged commit a306fd7 into PopeSpaceous:master Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.