Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed value: Crytogram to value: Cryptogram #151

Open
wants to merge 6 commits into
base: master
from

Conversation

@DavidLi119
Copy link

commented Mar 6, 2019

Changed for issue #108

@PopeSpaceous
Copy link
Owner

left a comment

Hi @DavidLi119
Thanks for the change.
I was wondering if you had tested the files (the in game cryptogram puzzle) and checked if they worked?

@PopeSpaceous
Copy link
Owner

left a comment

Hi David,
I tested the update and it causes the game to crash when you try to open the Cryptogram puzzles.
I recieved this error:
"Scene 'Cryptogram' couldn't be loaded because it has not been added to the build settings or the AssetBundle has not been loaded."

I think what is causing this is that the name change has broken the link to invoke the puzzle.
What you can do to find what needs to be changed is search the content of all the files with "crytogram" still there and that should point you to the files you need to change.

@PopeSpaceous

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

Try running this grep command in your local folder.
grep -ri "crytogram" .

@DavidLi119

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

Thanks, I'll get to it soon.

@DavidLi119

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

So I've made a commit of all files and the folder named Crytogram renamed to Cryptogram and all references I could find. I do not use a linux computer and for some reason grep does not work, command prompt or VSCode terminal. Please test

@PopeSpaceous

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

So I've made a commit of all files and the folder named Crytogram renamed to Cryptogram and all references I could find. I do not use a linux computer and for some reason grep does not work, command prompt or VSCode terminal. Please test

I'll give it a test when I can.
Fun Tip: If you are running on windows you can use linux commands through your GitBash shell. So long as it's installed you can right click and select open gitbash (and you'll be in that directory)

@DavidLi119

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

So i just used the file explorer and made a few more changes from cryt to crypt

@PopeSpaceous

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2019

So i just used the file explorer and made a few more changes from cryt to crypt

I'm still receiving an error in the game when I try to open a cryptogram puzzle. There are still some things that need changing. Here is a result from my grep search.

Assets/Scripts/PuzzleScripts/Cryptogram/CheckButton.cs: public Crytogram Cryptogram; Assets/Scripts/PuzzleScripts/Cryptogram/Cryptogram.cs:public class Crytogram: Puzzle { Assets/Scripts/PuzzleScripts/Cryptogram/Cryptogram.cs: puzzleName = "Crytogram"; Assets/Scripts/PuzzleScripts/Cryptogram/TextZone.cs: public Crytogram myCryp; Assets/Scripts/PuzzleScripts/PuzzleRandomization.cs: // refDictionary.Add ("Crytogram", new PlaceholderRefs (sprites_P [1], null)); // Spelling error, the scene name must be change first to fix this Assets/Scripts/PuzzleScripts/PuzzleRandomization.cs:

@DavidLi119

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

I made those changes already, looks like i forgot to push to origin. Just did it, sorry about that
I didnt change the one in the comment block though, if that is ok. If needed I can but I'm certain it won't do anything.
And apparently File Explorer Search Bar basically does the same thing as grep...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.