Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gobierto Open Data: People exports #528

Merged
merged 20 commits into from Mar 21, 2017
Merged

Conversation

amaia
Copy link
Contributor

@amaia amaia commented Mar 13, 2017

Connects to #303

What does this PR do?

Adds an open data page at /datos with the links to download data in csv and json formats for the GobiertoPeople module, and also an RSS feed for blog posts.
The page is linked form the people sidebar.

How should this be manually tested?

Check that the page exists at /datos and that you can download csv and json data and see the RSS feed

@codecov-io
Copy link

codecov-io commented Mar 13, 2017

Codecov Report

Merging #528 into stable will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           stable     #528     +/-   ##
=========================================
+ Coverage   91.06%   91.16%   +0.1%     
=========================================
  Files         213      220      +7     
  Lines        5000     5050     +50     
=========================================
+ Hits         4553     4604     +51     
+ Misses        447      446      -1
Impacted Files Coverage Δ
...rollers/gobierto_exports/application_controller.rb 100% <100%> (ø)
...ers/gobierto_people/person_statement_serializer.rb 100% <100%> (ø)
...ollers/gobierto_people/person_events_controller.rb 82.35% <100%> (+5.42%) ⬆️
app/models/gobierto_people/person_statement.rb 100% <100%> (ø) ⬆️
...p/controllers/gobierto_people/people_controller.rb 100% <100%> (ø) ⬆️
...obierto_people/person_event_attendee_serializer.rb 100% <100%> (ø)
...gobierto_people/content_block_record_serializer.rb 100% <100%> (ø)
app/models/gobierto_people/person_event.rb 100% <100%> (ø) ⬆️
...rollers/gobierto_people/person_posts_controller.rb 100% <100%> (ø) ⬆️
...rs/gobierto_people/person_statements_controller.rb 100% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf5125...1a1b962. Read the comment docs.

@furilo
Copy link
Member

furilo commented Mar 15, 2017

  • Section title: "Descarga datos"
  • URL slug: /datos
  • Add the right link to the user sidebar in People module:

captura de pantalla 2017-03-15 a las 17 21 21

@amaia amaia changed the title [WIP] Gobierto Open Data: People exports Gobierto Open Data: People exports Mar 15, 2017
@amaia amaia force-pushed the 303-gobierto-people-exports branch from 01edc92 to 7f42506 Compare March 15, 2017 19:16
@amaia amaia force-pushed the 303-gobierto-people-exports branch from ff371a7 to 9998875 Compare March 15, 2017 19:24
Copy link
Member

@ferblape ferblape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have completed a bit the test of the exports page. The rest of the PR is ok.

@ferblape ferblape merged commit eb2e01b into stable Mar 21, 2017
@ferblape ferblape deleted the 303-gobierto-people-exports branch March 21, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants