test(clickhouse): wait on desired state, not intermediary #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using kubernetes details to decide if ClickHouse had scaled up correctly. This appeared to fail quite regularly though, so instead I am using one ClickHouse properties to decide if we converge on the desired state.
added 2 commits
May 10, 2022 11:45
guidoiaquinti
approved these changes
May 10, 2022
|
We probably forgot to bump the chart with this merge. No worries head over to https://github.com/PostHog/charts-clickhouse/actions/workflows/bump-version-workflow-dispatch.yaml to trigger the chart update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using kubernetes details to decide if ClickHouse had
scaled up correctly. This appeared to fail quite regularly though, so
instead I am using one ClickHouse properties to decide if we converge on
the desired state.
Description
Type of change
How has this been tested?
Checklist