fix: permission panel scrolls the dialog box not the bottom container#2333
Open
ShekharDhangar wants to merge 1 commit into
Open
fix: permission panel scrolls the dialog box not the bottom container#2333ShekharDhangar wants to merge 1 commit into
ShekharDhangar wants to merge 1 commit into
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix: permission panel scrolls the dialog..." | Re-trigger Greptile |
d3bf8f1 to
f1ff63e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2289
Summary
max-h-[50vh] overflow-y-autofrom the outerSessionViewwrapper to theActionSelectorbox itself, so the scroll appears on the bordered dialog box rather than the app's bottom panelmax-h-[30vh] overflow-autowrappers fromExecutePermissionandMcpPermissionto avoid double scrollbarsmax-h-1/2 min-h-0fromSessionView—max-h-1/2(percentage) doesn't resolve in a flex container without a definite parent height, so it never actually constrained anythingDemo
posthog_code.mp4
Test plan
Created with PostHog Code