Skip to content

fix: permission panel scrolls the dialog box not the bottom container#2333

Open
ShekharDhangar wants to merge 1 commit into
PostHog:mainfrom
ShekharDhangar:fix/permission-panel-scroll
Open

fix: permission panel scrolls the dialog box not the bottom container#2333
ShekharDhangar wants to merge 1 commit into
PostHog:mainfrom
ShekharDhangar:fix/permission-panel-scroll

Conversation

@ShekharDhangar
Copy link
Copy Markdown

@ShekharDhangar ShekharDhangar commented May 24, 2026

Fixes #2289

Summary

  • Moves max-h-[50vh] overflow-y-auto from the outer SessionView wrapper to the ActionSelector box itself, so the scroll appears on the bordered dialog box rather than the app's bottom panel
  • Removes the now-redundant inner max-h-[30vh] overflow-auto wrappers from ExecutePermission and McpPermission to avoid double scrollbars
  • Removes the broken max-h-1/2 min-h-0 from SessionViewmax-h-1/2 (percentage) doesn't resolve in a flex container without a definite parent height, so it never actually constrained anything

Demo

posthog_code.mp4

Test plan

  • Trigger a permission dialog with a long command (e.g. ask Codex to write a file with large content)
  • Verify the scroll appears on the bordered dialog box, not the bottom bar
  • Verify buttons (Yes, proceed etc.) are reachable by scrolling within the dialog
  • Trigger an MCP tool permission with large JSON input and verify the same behaviour

Created with PostHog Code

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 24, 2026

Reviews (1): Last reviewed commit: "fix: permission panel scrolls the dialog..." | Re-trigger Greptile

@ShekharDhangar ShekharDhangar force-pushed the fix/permission-panel-scroll branch from d3bf8f1 to f1ff63e Compare May 24, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long command approvals overflow the full bottom container

1 participant