From f1ff63ef02a05ddd3a2a133052fd40eafa064635 Mon Sep 17 00:00:00 2001 From: shekhardhangar Date: Sun, 24 May 2026 15:50:37 +0530 Subject: [PATCH] fix: permission panel scrolls the dialog box not the bottom container --- .../action-selector/ActionSelector.tsx | 2 +- .../permissions/ExecutePermission.tsx | 18 ++++++++---------- .../components/permissions/McpPermission.tsx | 16 +++++++--------- .../sessions/components/SessionView.tsx | 2 +- 4 files changed, 17 insertions(+), 21 deletions(-) diff --git a/apps/code/src/renderer/components/action-selector/ActionSelector.tsx b/apps/code/src/renderer/components/action-selector/ActionSelector.tsx index 21cb94f8e..cd9120264 100644 --- a/apps/code/src/renderer/components/action-selector/ActionSelector.tsx +++ b/apps/code/src/renderer/components/action-selector/ActionSelector.tsx @@ -216,7 +216,7 @@ export function ActionSelector({ style={{ outline: "none", }} - className="rounded-(--radius-3) border border-(--gray-6) bg-(--gray-1)" + className="max-h-[50vh] overflow-y-auto rounded-(--radius-3) border border-(--gray-6) bg-(--gray-1)" > {hasSteps && steps && ( diff --git a/apps/code/src/renderer/components/permissions/ExecutePermission.tsx b/apps/code/src/renderer/components/permissions/ExecutePermission.tsx index b7066b9fe..61bfe8324 100644 --- a/apps/code/src/renderer/components/permissions/ExecutePermission.tsx +++ b/apps/code/src/renderer/components/permissions/ExecutePermission.tsx @@ -1,5 +1,5 @@ import { ActionSelector } from "@components/ActionSelector"; -import { Box, Code } from "@radix-ui/themes"; +import { Code } from "@radix-ui/themes"; import { compactHomePath } from "@utils/path"; import { type BasePermissionProps, @@ -20,15 +20,13 @@ export function ExecutePermission({ title={toolCall.title ?? "Execute command"} pendingAction={ command ? ( - - - {compactHomePath(command)} - - + + {compactHomePath(command)} + ) : undefined } question="Do you want to proceed?" diff --git a/apps/code/src/renderer/components/permissions/McpPermission.tsx b/apps/code/src/renderer/components/permissions/McpPermission.tsx index 375926665..100856123 100644 --- a/apps/code/src/renderer/components/permissions/McpPermission.tsx +++ b/apps/code/src/renderer/components/permissions/McpPermission.tsx @@ -6,7 +6,7 @@ import { isPostHogExecTool, } from "@features/posthog-mcp/utils/posthog-exec-display"; import { formatInput } from "@features/sessions/components/session-update/toolCallUtils"; -import { Box, Code } from "@radix-ui/themes"; +import { Code } from "@radix-ui/themes"; import { DefaultPermission } from "./DefaultPermission"; import { type BasePermissionProps, toSelectorOptions } from "./types"; @@ -54,14 +54,12 @@ export function McpPermission({ } pendingAction={ fullInput ? ( - - - {fullInput} - - + + {fullInput} + ) : undefined } question="Do you want to proceed?" diff --git a/apps/code/src/renderer/features/sessions/components/SessionView.tsx b/apps/code/src/renderer/features/sessions/components/SessionView.tsx index b95675e7d..eb74c619d 100644 --- a/apps/code/src/renderer/features/sessions/components/SessionView.tsx +++ b/apps/code/src/renderer/features/sessions/components/SessionView.tsx @@ -581,7 +581,7 @@ export function SessionView({ ) : hideInput ? null : firstPendingPermission ? ( - +