Skip to content

fix: permission panel scrolls the dialog box not the bottom container #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShekharDhangar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: permission panel scrolls the dialog box not the bottom container #2333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/code/src/renderer/components/action-selector/ActionSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export function ActionSelector({
style={{
outline: "none",
}}
className="rounded-(--radius-3) border border-(--gray-6) bg-(--gray-1)"
className="max-h-[50vh] overflow-y-auto rounded-(--radius-3) border border-(--gray-6) bg-(--gray-1)"
>
<Flex direction="column" gap="2">
{hasSteps && steps && (
Expand Down
18 changes: 8 additions & 10 deletions apps/code/src/renderer/components/permissions/ExecutePermission.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ActionSelector } from "@components/ActionSelector";
import { Box, Code } from "@radix-ui/themes";
import { Code } from "@radix-ui/themes";
import { compactHomePath } from "@utils/path";
import {
type BasePermissionProps,
Expand All @@ -20,15 +20,13 @@ export function ExecutePermission({
title={toolCall.title ?? "Execute command"}
pendingAction={
command ? (
<Box className="max-h-[30vh] overflow-auto">
<Code
variant="ghost"
title={command}
className="whitespace-pre-wrap break-all text-[13px]"
>
{compactHomePath(command)}
</Code>
</Box>
<Code
variant="ghost"
title={command}
className="whitespace-pre-wrap break-all text-[13px]"
>
{compactHomePath(command)}
</Code>
) : undefined
}
question="Do you want to proceed?"
Expand Down
16 changes: 7 additions & 9 deletions apps/code/src/renderer/components/permissions/McpPermission.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
isPostHogExecTool,
} from "@features/posthog-mcp/utils/posthog-exec-display";
import { formatInput } from "@features/sessions/components/session-update/toolCallUtils";
import { Box, Code } from "@radix-ui/themes";
import { Code } from "@radix-ui/themes";
import { DefaultPermission } from "./DefaultPermission";
import { type BasePermissionProps, toSelectorOptions } from "./types";

Expand Down Expand Up @@ -54,14 +54,12 @@ export function McpPermission({
}
pendingAction={
fullInput ? (
<Box className="max-h-[30vh] overflow-auto">
<Code
variant="ghost"
className="whitespace-pre-wrap break-all text-[13px]"
>
{fullInput}
</Code>
</Box>
<Code
variant="ghost"
className="whitespace-pre-wrap break-all text-[13px]"
>
{fullInput}
</Code>
) : undefined
}
question="Do you want to proceed?"
Expand Down
2 changes: 1 addition & 1 deletion apps/code/src/renderer/features/sessions/components/SessionView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ export function SessionView({
</Flex>
</Flex>
) : hideInput ? null : firstPendingPermission ? (
<Box className="max-h-1/2 min-h-0 overflow-y-auto border-gray-4 border-t">
<Box className="border-gray-4 border-t">
<Box
className={compact ? "p-1" : "mx-auto p-2"}
style={
Expand Down