Skip to content

chore(code): add prompt sent event to cloud tasks#2532

Merged
charlesvien merged 1 commit into
mainfrom
06-08-chore_code_add_prompt_sent_event_to_cloud_tasks
Jun 9, 2026
Merged

chore(code): add prompt sent event to cloud tasks#2532
charlesvien merged 1 commit into
mainfrom
06-08-chore_code_add_prompt_sent_event_to_cloud_tasks

Conversation

@adboio

@adboio adboio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Problem

this is not 100% accurate because we only track "prompt sent" for local tasks https://us.posthog.com/project/2/insights/9A5loOF4

Changes

adds "prompt sent" event to cloud tasks

How did you test this?

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

adboio commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit c552a27.

@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/sagas/task/task-creation.ts:325
**`prompt_length_chars` measurement differs from local tracking**

`transport.promptText` is `buildCloudTaskDescription` output, which appends `"Attached files: file1, file2, …"` when files are present. For a file-only cloud prompt (no text body), `messageText` is `undefined` but `promptText` is a non-empty attachment summary, so `prompt_length_chars` will report a non-zero length for what is effectively an empty text prompt. The local equivalent uses only the pure text (`extractPromptText`), so the two paths are inconsistent. Using `transport.messageText?.length ?? 0` would match the local meaning; if tracking files-sent information matters, a separate `has_attachment` property on `PromptSentProperties` would be cleaner than relying on the length signal.

Reviews (1): Last reviewed commit: "chore(code): add prompt sent event to cl..." | Re-trigger Greptile

Comment thread apps/code/src/renderer/sagas/task/task-creation.ts Outdated
@adboio adboio marked this pull request as ready for review June 8, 2026 19:38
@adboio adboio requested a review from a team June 8, 2026 19:38
@adboio adboio force-pushed the 06-08-chore_code_add_prompt_sent_event_to_cloud_tasks branch from eb59584 to c552a27 Compare June 8, 2026 19:40
@charlesvien charlesvien merged commit 0534654 into main Jun 9, 2026
20 checks passed
@charlesvien charlesvien deleted the 06-08-chore_code_add_prompt_sent_event_to_cloud_tasks branch June 9, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants