From 4e0a5469b365a1e0a3e63348c0a08ed46ca8b9f5 Mon Sep 17 00:00:00 2001
From: Xavier Vello <xavier@posthog.com>
Date: Mon, 6 May 2024 14:30:55 +0200
Subject: [PATCH] improve testing

---
 hook-worker/src/dns.rs | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/hook-worker/src/dns.rs b/hook-worker/src/dns.rs
index d55a281..36fd7a0 100644
--- a/hook-worker/src/dns.rs
+++ b/hook-worker/src/dns.rs
@@ -108,7 +108,7 @@ mod tests {
             .await
         {
             Ok(_) => panic!("should have failed"),
-            Err(err) => assert!(err.downcast_ref::<NoPublicIPv4Error>().is_some()),
+            Err(err) => assert!(err.is::<NoPublicIPv4Error>()),
         }
     }
 
@@ -122,16 +122,19 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn it_propagates_unknown_domain() {
+    async fn it_bubbles_up_resolution_error() {
         let resolver: PublicIPv4Resolver = PublicIPv4Resolver {};
         match resolver
             .resolve(Name::from_str("invalid.domain.unknown").unwrap())
             .await
         {
             Ok(_) => panic!("should have failed"),
-            Err(err) => assert!(err
-                .to_string()
-                .contains("failed to lookup address information")),
+            Err(err) => {
+                assert!(!err.is::<NoPublicIPv4Error>());
+                assert!(err
+                    .to_string()
+                    .contains("failed to lookup address information"))
+            }
         }
     }
 }