Skip to content

Remove the usage of is_simple_flag #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Remove the usage of is_simple_flag #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions posthog/test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ def test_basic_capture_with_locally_evaluated_feature_flags(self, patch_decide):
"id": 1,
"name": "Beta Feature",
"key": "beta-feature-local",
"is_simple_flag": False,
"active": True,
"rollout_percentage": 100,
"filters": {
Expand Down Expand Up @@ -321,7 +320,6 @@ def test_basic_capture_with_locally_evaluated_feature_flags(self, patch_decide):
"id": 1,
"name": "Beta Feature",
"key": "person-flag",
"is_simple_flag": True,
"active": True,
"filters": {
"groups": [
Expand All @@ -344,7 +342,6 @@ def test_basic_capture_with_locally_evaluated_feature_flags(self, patch_decide):
"id": 1,
"name": "Beta Feature",
"key": "false-flag",
"is_simple_flag": True,
"active": True,
"filters": {
"groups": [
Expand Down Expand Up @@ -396,7 +393,6 @@ def test_dont_override_capture_with_local_flags(self, patch_decide):
"id": 1,
"name": "Beta Feature",
"key": "beta-feature-local",
"is_simple_flag": False,
"active": True,
"rollout_percentage": 100,
"filters": {
Expand Down Expand Up @@ -425,7 +421,6 @@ def test_dont_override_capture_with_local_flags(self, patch_decide):
"id": 1,
"name": "Beta Feature",
"key": "person-flag",
"is_simple_flag": True,
"active": True,
"filters": {
"groups": [
Expand Down Expand Up @@ -1039,7 +1034,7 @@ def raise_effect():

patch_get.return_value.raiseError.side_effect = raise_effect
client = Client(FAKE_TEST_API_KEY, personal_api_key="test")
client.feature_flags = [{"key": "example", "is_simple_flag": False}]
client.feature_flags = [{"key": "example"}]

self.assertFalse(client.feature_enabled("example", "distinct_id"))

Expand Down
Loading