Skip to content

Conversation

@pauldambra
Copy link
Member

ok, next error

sed: can't read : No such file or directory
sed: can't read : No such file or directory
sed: can't read : No such file or directory
sed: can't read : No such file or directory
sed: can't read : No such file or directory
sed: can't read : No such file or directory
rm -rf posthog
python setup_analytics.py sdist bdist_wheel
Traceback (most recent call last):
  File "/home/runner/work/posthog-python/posthog-python/setup_analytics.py", line 3, in <module>
    import tomli
ModuleNotFoundError: No module named 'tomli'

two things

an error we've not seen or ignored because we're using sed with a mac os flag that doesn't work on linux in CI

and then installing tomli in the wrong dependency group

@pauldambra pauldambra requested a review from a team June 9, 2025 10:23
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed cross-platform build system issues in the Python package release process.

  • Modified Makefile to use platform-agnostic sed commands with -i.bak instead of macOS-specific -i '' syntax
  • Added tomli and tomli_w to build dependencies in pyproject.toml to fix package build failures
  • Improved file handling in release process to specifically target .py files and clean up .bak files after sed operations

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@pauldambra pauldambra enabled auto-merge (squash) June 9, 2025 10:31
@pauldambra pauldambra merged commit 24d8980 into master Jun 9, 2025
6 checks passed
@pauldambra pauldambra deleted the chore/ci/more-fiddling branch June 9, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants