chore: instrument time insights are marked as loading #11222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
reviewed
Aug 11, 2022
Comment on lines
755
to
757
| loadDashboardItemsSuccess: () => { | ||
| // I didn't want any parameters but kea does :) | ||
| sharedListeners.reportLoadTiming(null, async () => {}, {} as { type: string; payload: any }, null) |
There was a problem hiding this comment.
I think you can do something like this instead:
Suggested change
| loadDashboardItemsSuccess: () => { | |
| // I didn't want any parameters but kea does :) | |
| sharedListeners.reportLoadTiming(null, async () => {}, {} as { type: string; payload: any }, null) | |
| loadDashboardItemsSuccess: (...args) => { | |
| sharedListeners.reportLoadTiming(...args) |
| @@ -2,7 +2,7 @@ import { isBreakpoint, kea } from 'kea' | |||
| import api from 'lib/api' | |||
| import { dashboardsModel } from '~/models/dashboardsModel' | |||
| import { router } from 'kea-router' | |||
| import { dayjs, now } from 'lib/dayjs' | |||
| import { Dayjs, dayjs, now } from 'lib/dayjs' | |||
There was a problem hiding this comment.
kea-typegen gets confused because of Dayjs being imported for some reason… But also Day.js seems overkill for this, Date should be able to do the job too
benjackwhite
approved these changes
Aug 11, 2022
| @@ -27,6 +26,7 @@ import { teamLogic } from '../teamLogic' | |||
| import { urls } from 'scenes/urls' | |||
| import { userLogic } from 'scenes/userLogic' | |||
| import { mergeWithDashboardTile } from 'scenes/insights/utils/dashboardTiles' | |||
| import { dayjs, now } from 'lib/dayjs' | |||
There was a problem hiding this comment.
I think these were forgotten to be removed?
There was a problem hiding this comment.
Interestingly. We use dayjs elsewhere in the file already but we never return the Dayjs type. So kea typegen never has to deal with it.
I thought I'd not rewrite existing functionality since there's a good chance we leave this in for a few days to get a snapshot of data and then remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't know how long people see Insight loading skeletons for
And want to know that to inform design work
Changes
dashboard loading timeevent. Which is a (reasonable) proxy for the time someone would be seeing skeleton loaders on the dashboardinsight refresh time. Which is a reasonable proxy for the time someone would be seeing loaders over the insight cards on a dashboardHow did you test this code?
running it locally to see the capture calls made