Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Remove Autocapture functionality from Paths #5895

Merged
merged 5 commits into from Sep 20, 2021
Merged

Proposal: Remove Autocapture functionality from Paths #5895

merged 5 commits into from Sep 20, 2021

Conversation

neilkakkar
Copy link
Collaborator

Changes

#5665 (comment)

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@timgl timgl temporarily deployed to posthog-pr-5895 September 10, 2021 13:19 Inactive
@timgl timgl temporarily deployed to posthog-pr-5895 September 10, 2021 13:45 Inactive
@macobo
Copy link
Contributor

macobo commented Sep 10, 2021

Love it! :)

@EDsCODE EDsCODE temporarily deployed to posthog-pr-5895 September 10, 2021 19:43 Inactive
paolodamico
paolodamico reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but I don't have enough context to review this part of the codebase, think it's worth waiting for @EDsCODE's comments.

@EDsCODE EDsCODE temporarily deployed to posthog-pr-5895 September 13, 2021 18:05 Inactive
neilkakkar
neilkakkar commented Sep 20, 2021
View reviewed changes
posthog/queries/paths.py Outdated Show resolved Hide resolved
@neilkakkar neilkakkar enabled auto-merge (squash) September 20, 2021 14:58
@neilkakkar neilkakkar mentioned this pull request Sep 20, 2021
Merged
6 tasks
@neilkakkar neilkakkar merged commit d6e410b into master Sep 20, 2021
@neilkakkar neilkakkar deleted the yeet-autocapture branch September 20, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolodamico paolodamico paolodamico left review comments

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@neilkakkar @macobo @paolodamico @EDsCODE @timgl