Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use hasql-pool with connection lifetime option #2663

Merged
merged 2 commits into from Apr 6, 2023
Merged

use hasql-pool with connection lifetime option #2663

merged 2 commits into from Apr 6, 2023

Conversation

robx
Copy link
Contributor

@robx robx commented Feb 14, 2023 •
edited

This uses the new hasql-pool-0.9 to add db-pool-max-lifetime.

steve-chavez
steve-chavez reviewed Feb 14, 2023
View reviewed changes
src/PostgREST/CLI.hs Outdated Show resolved Hide resolved
@robx robx mentioned this pull request Feb 14, 2023
Closed
@robx robx marked this pull request as ready for review April 6, 2023 12:21
@robx robx requested a review from steve-chavez April 6, 2023 12:24
steve-chavez
steve-chavez approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

@robx robx force-pushed the pool-lifetime branch 2 times, most recently from 4491a37 to fcca5f2 Compare April 6, 2023 18:33
robx added 2 commits April 6, 2023 20:34
@robx
test: stabilize log probe in test_pool_acquisition_timeout
6e35778 
There's two lines of log output, and their order is not deterministic.
@robx
feat: use hasql-pool-0.9, add db-pool-max-lifetime (fixes PostgREST#2638
09447c5 
)

- db-pool-acquisition-timeout is no longer optional, defaults to 10s
- new option db-pool-max-lifetime limits the maximal lifetime of a
  postgresql connection, defaults to 30m
@robx robx merged commit 394bd22 into PostgREST:main Apr 6, 2023
27 checks passed
@robx robx deleted the pool-lifetime branch April 6, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-chavez steve-chavez steve-chavez approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robx @steve-chavez