Allow configure from yaml to work with yml.erb files #9

Merged
merged 5 commits into from Mar 15, 2012

Projects

None yet

2 participants

@carlosantoniodasilva

This allows abstracting configs such as tokens from the yaml file in setups like Heroku, that are readonly. By using ERB it's possible to make use of ENV vars to configure the yaml file.

I've also made some minor refactorings, removed a deprecation warning from RSpec, and changed the gemfile to use ~> for ActiveResource and RSpec dependencies. All tests are green.

Let me know if something can be improved, thanks.

@carlosantoniodasilva carlosantoniodasilva Prefer ~> over >= for gems in gemspec
There is a great chance for this to break with versions like Rails 4
(that has just removed ActiveResource from core) or RSpec 3 when
released. Use a safer setup.
4c43c5c
@carlosantoniodasilva carlosantoniodasilva Only use attr_writer for primary_key, as the reader method exists 6721709
@carlosantoniodasilva carlosantoniodasilva Remove rspec deprecation warning and add default task
So you can run "rake" instead of "rake spec"
b60c481
@carlosantoniodasilva carlosantoniodasilva Refactor rails spec 6bfb496
@carlosantoniodasilva carlosantoniodasilva Allow configure using yaml ERB files
This allows using ENV vars and other ERB goodness if required. A good
example is to use with heroku ENV vars.
665bf5d
@mahmoudimus

oh man thanks for doing this! I've wanted to do it for some time.

@mahmoudimus

Thanks!

@mahmoudimus mahmoudimus merged commit 353202a into PoundPay:master Mar 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment