From c8166ef4da5e2ba37953b7af1c59ddf41117868d Mon Sep 17 00:00:00 2001
From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Mon, 9 Oct 2023 20:08:53 +0200
Subject: [PATCH] switch notimpStats to array, thanks @rgacogne

---
 pdns/ixfrdist-stats.cc                  | 8 ++++++--
 pdns/ixfrdist-stats.hh                  | 6 +++---
 pdns/ixfrdist.cc                        | 2 +-
 regression-tests.ixfrdist/test_Stats.py | 3 ++-
 4 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/pdns/ixfrdist-stats.cc b/pdns/ixfrdist-stats.cc
index 0a545c59c177..b0db5f3294fd 100644
--- a/pdns/ixfrdist-stats.cc
+++ b/pdns/ixfrdist-stats.cc
@@ -90,8 +90,12 @@ std::string ixfrdistStats::getStats() {
     stats<<"# TYPE "<<prefix<<"notimp counter"<<std::endl;
   }
 
-  for (auto const &d : notimpStats) {
-    stats<<prefix<<"notimp{opcode=\""<<d.first<<"\"} "<<d.second<<std::endl;
+  for (std::size_t i = 0; i < notimpStats.size() ; i++) {
+    auto val = notimpStats.at(i).load();
+
+    if (val > 0) {
+      stats<<prefix<<"notimp{opcode=\""<<Opcode::to_s(i)<<"\"} "<<val<<std::endl;
+    }
   }
 
   stats<<"# HELP "<<prefix<<"unknown_domain_inqueries_total Number of queries received for domains unknown to us"<<std::endl;
diff --git a/pdns/ixfrdist-stats.hh b/pdns/ixfrdist-stats.hh
index cb1f402d71ea..f9dbe828a6f4 100644
--- a/pdns/ixfrdist-stats.hh
+++ b/pdns/ixfrdist-stats.hh
@@ -71,9 +71,9 @@ class ixfrdistStats {
       progStats.unknownDomainInQueries += 1;
     }
 
-    void incrementNotImplemented(const string& opcode)
+    void incrementNotImplemented(uint8_t opcode)
     {
-      notimpStats[opcode] ++;
+      notimpStats.at(opcode) ++;
     }
 
   private:
@@ -99,7 +99,7 @@ class ixfrdistStats {
     };
 
     std::map<DNSName, perDomainStat> domainStats;
-    std::map<string, std::atomic<uint64_t>> notimpStats;
+    std::array<std::atomic<uint64_t>, 16> notimpStats;
     programStats progStats;
 
     std::map<DNSName, perDomainStat>::iterator getRegisteredDomain(const DNSName& d) {
diff --git a/pdns/ixfrdist.cc b/pdns/ixfrdist.cc
index 52b6599d1c63..730b79b52240 100644
--- a/pdns/ixfrdist.cc
+++ b/pdns/ixfrdist.cc
@@ -959,7 +959,7 @@ try
     g_stats.incrementUnknownDomainInQueries(mdp.d_qname);
     makeRefusedPacket(mdp, packet);
   } else if (respt == ResponseType::RefusedOpcode) {
-    g_stats.incrementNotImplemented(Opcode::to_s(mdp.d_header.opcode));
+    g_stats.incrementNotImplemented(mdp.d_header.opcode);
     makeNotimpPacket(mdp, packet);
   }
 
diff --git a/regression-tests.ixfrdist/test_Stats.py b/regression-tests.ixfrdist/test_Stats.py
index d9c8c8c35b98..e3f6e7a84835 100644
--- a/regression-tests.ixfrdist/test_Stats.py
+++ b/regression-tests.ixfrdist/test_Stats.py
@@ -33,7 +33,8 @@ class IXFRDistStatsTest(IXFRDistTest):
                          "ixfrdist_unknown_domain_inqueries_total",
                          "ixfrdist_sys_msec", "ixfrdist_user_msec",
                          "ixfrdist_real_memory_usage",
-                         "ixfrdist_fd_usage"]
+                         "ixfrdist_fd_usage",
+                         "ixfrdist_notimp"]
     metric_domain_stats = ["ixfrdist_soa_serial", "ixfrdist_soa_checks_total",
                            "ixfrdist_soa_checks_failed_total",
                            "ixfrdist_soa_inqueries_total",