diff --git a/pdns/communicator.hh b/pdns/communicator.hh index a7f95b81da31..f646b2226505 100644 --- a/pdns/communicator.hh +++ b/pdns/communicator.hh @@ -244,18 +244,32 @@ private: class FindNS { public: - vector lookup(const DNSName &name, UeberBackend *b) + vector lookup(const DNSName &name, UeberBackend *b, const DNSName& zone) { vector addresses; this->resolve_name(&addresses, name); if(b) { - b->lookup(QType(QType::ANY),name); - DNSZoneRecord rr; - while(b->get(rr)) - if(rr.dr.d_type == QType::A || rr.dr.d_type==QType::AAAA) + b->lookup(QType(QType::ANY),name); + while (true) { + try { + DNSZoneRecord rr; + if (!b->get(rr)) + break; + if (rr.dr.d_type == QType::A || rr.dr.d_type == QType::AAAA) addresses.push_back(rr.dr.d_content->getZoneRepresentation()); // SOL if you have a CNAME for an NS + } + // After an exception, b can be inconsistent so break + catch (PDNSException &ae) { + L << Logger::Error << "Could not lookup address for nameserver " << name << " in zone " << zone << ", cannot notify: " << ae.reason << endl; + break; + } + catch (std::exception &e) { + L << Logger::Error << "Could not lookup address for nameserver " << name << " in zone " << zone << ", cannot notify: " << e.what() << endl; + break; + } + } } return addresses; } diff --git a/pdns/mastercommunicator.cc b/pdns/mastercommunicator.cc index 456957a80d78..8be9ebad9ef1 100644 --- a/pdns/mastercommunicator.cc +++ b/pdns/mastercommunicator.cc @@ -56,7 +56,7 @@ void CommunicatorClass::queueNotifyDomain(const DomainInfo& di, UeberBackend* B) nsset.insert(getRR(rr.dr)->getNS().toString()); for(set::const_iterator j=nsset.begin();j!=nsset.end();++j) { - vector nsips=fns.lookup(DNSName(*j), B); + vector nsips=fns.lookup(DNSName(*j), B, di.zone); if(nsips.empty()) L< q) while(B->get(rr)) nsset.insert(DNSName(rr.content)); for(const auto & j: nsset) { - vector nsips=fns.lookup(j, s_P->getBackend()); + vector nsips=fns.lookup(j, s_P->getBackend(),q->qdomain); for(vector::const_iterator k=nsips.begin();k!=nsips.end();++k) { // cerr<<"got "<<*k<<" from AUTO-NS"<getRemote().toString())