Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist 1.6.0-alpha1 "handling auth for" log spam #10049

Closed
gryphius opened this issue Feb 3, 2021 · 1 comment · Fixed by #10050
Closed

dnsdist 1.6.0-alpha1 "handling auth for" log spam #10049

gryphius opened this issue Feb 3, 2021 · 1 comment · Fixed by #10050
Assignees
Labels
Milestone

Comments

@gryphius
Copy link
Contributor

gryphius commented Feb 3, 2021

  • Program: dnsdist
  • Issue type: Bug report

Short description

we use tools to monitor the state of dnsdist over the api every few seconds.
Since dnsdist 1.6.0alpha1 these requests now cause the log being flodded with messages such as:

Feb 03 10:06:47 poike.switch.ch dnsdist[8976]: handling auth for /jsonstat
Feb 03 10:06:48 poike.switch.ch dnsdist[8976]: handling auth for /jsonstat
Feb 03 10:06:48 poike.switch.ch dnsdist[8976]: handling auth for /jsonstat
Feb 03 10:06:48 poike.switch.ch dnsdist[8976]: handling auth for /jsonstat
Feb 03 10:06:48 poike.switch.ch dnsdist[8976]: handling auth for /api/v1/servers/localhost
Feb 03 10:06:49 poike.switch.ch dnsdist[8976]: handling auth for /api/v1/servers/localhost
Feb 03 10:06:49 poike.switch.ch dnsdist[8976]: handling auth for /jsonstathandling auth for /jsonstat
Feb 03 10:06:49 poike.switch.ch dnsdist[8976]: handling auth for /api/v1/servers/localhost
Feb 03 10:06:49 poike.switch.ch dnsdist[8976]: handling auth for /jsonstat

Environment

  • Operating system: centos7
  • Software version: dnsdist 1.6.0-alpha1 (Lua 5.1.4 [LuaJIT 2.0.4])
  • Software source: compiled ourselves

Steps to reproduce

  • make a request to the api
  • check the log

Expected behaviour

no log entry (maybe unless some debug level is configured)

Actual behaviour

log message for every request

Other information

introcuced in fa7e8b5

static bool handleAuthorization(const YaHTTP::Request& req)
{
  cerr<<"handling auth for "<<req.url.path<<endl;
@gryphius gryphius changed the title dnsdist 1.6.0-alpha1 "handligh auth for" log spam dnsdist 1.6.0-alpha1 "handling auth for" log spam Feb 3, 2021
@pieterlexis pieterlexis removed the defect label Feb 3, 2021
@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Feb 3, 2021
@rgacogne
Copy link
Member

rgacogne commented Feb 3, 2021

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants