Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ponder replacing pthread_rwlock with std::shared_mutex #10209

Closed
rgacogne opened this issue Mar 23, 2021 · 0 comments · Fixed by #10216
Closed

Ponder replacing pthread_rwlock with std::shared_mutex #10209

rgacogne opened this issue Mar 23, 2021 · 0 comments · Fixed by #10216
Labels
auth dnsdist enhancement rec

Comments

@rgacogne
Copy link
Member

  • Program: Authoritative, Recursor, dnsdist
  • Issue type: Clean up request

Short description

std::shared_mutex was introduced in C++17 and is mostly a wrapper around pthread_rwlock on most platforms, but with RAII semantics preventing misuses.
Since we already wrap pthread_rwlock in the ReadWriteLock class that should hopefully not be too painful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth dnsdist enhancement rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace pthread_rwlock with std::shared_mutex rgacogne/pdns
1 participant
@rgacogne