Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: dnstap writes down wrong protocol #10497

Closed
tomverrecktecheib opened this issue Jun 15, 2021 · 0 comments · Fixed by #10537
Closed

dnsdist: dnstap writes down wrong protocol #10497

tomverrecktecheib opened this issue Jun 15, 2021 · 0 comments · Fixed by #10537

Comments

@tomverrecktecheib
Copy link

  • Program: dnsdist
  • Issue type: Bug report

Short description

Dnstap writes down wrong protocol (see https://mailman.powerdns.com/pipermail/dnsdist/2021-June/001090.html). When querying dnsdist with DoH (tcp), dnstap shows UDP.

Environment

  • Operating system: ---
  • Software version: 1.5.2
  • Software source: self-compiled

Steps to reproduce

  1. Query dnsdist with DoH (dig @10.1.1.1 +https google.com)

Expected behaviour

I expect to see TCP for the DoH query in the dnstap logfile.

Actual behaviour

Dnstap writes down the wrong protocol (UDP instead of TCP).

$ dnstap-read -p 2021-06-13-dnstap.fstrm
...
...
14-Jun-2021 14:19:30.058 CQ x.x.x.x:44749 -> y.y.y.y:443 UDP 51b google.com/IN/A
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id:   1015
;; flags: rd ad; QUESTION: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
; COOKIE: 1f5e39ad95e85cd8
;; QUESTION SECTION:
;google.com.            IN    A

14-Jun-2021 14:19:30.059 CR x.x.x.x:44749 <- y.y.y.y:443 UDP 83b google.com/IN/A
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id:   1015
;; flags: qr rd ra; QUESTION: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
; COOKIE: 1f5e39ad95e85cd80100000060c74952f681b113fec0d503
;; QUESTION SECTION:
;google.com.            IN    A

;; ANSWER SECTION:
google.com.        266    IN    A    216.58.215.238
...
...

Other information

@Habbie Habbie added the dnsdist label Jun 15, 2021
@omoerbeek omoerbeek changed the title dnstap writes down wrong protocol dnsdist: dnstap writes down wrong protocol Jun 15, 2021
@rgacogne rgacogne added this to the dnsdist-1.6.x milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants