Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Be consistent about "ruleRefused", "ruleNXDomain" and "ruleServFail" counters #11498

Closed
rgacogne opened this issue Apr 4, 2022 · 1 comment · Fixed by #12484
Closed

Comments

@rgacogne
Copy link
Member

rgacogne commented Apr 4, 2022

  • Program: dnsdist
  • Issue type: Bug report

Short description

Setting a response code via RCodeAction does not increase these counters and should. We might also want to check whether we correctly update the ruleTruncated one.

@aj-gh
Copy link
Contributor

aj-gh commented Apr 4, 2022

As discussed this causes the metrics for rule-nxdomain / rule-refused / rule-servfail to be off as they don't count these replies.
(Just mentioning so this is found when searching issues on the exact metric names)

This seems to be handled via DNSAction::Action::HeaderModify instead of, for example, DNSAction::Action::Refused where this would be counted.
At least self-answered is correct 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants