Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add queries/responses handled by packetcache into ringbuffers? #11585

Closed
aj-gh opened this issue Apr 27, 2022 · 0 comments · Fixed by #11712
Closed

dnsdist: Add queries/responses handled by packetcache into ringbuffers? #11585

aj-gh opened this issue Apr 27, 2022 · 0 comments · Fixed by #11712

Comments

@aj-gh
Copy link
Contributor

aj-gh commented Apr 27, 2022

  • Program: dnsdist
  • Issue type: Bug report / Feature Request

Short description

Queries handled by the packet cache don't seem to end up in the ringbuffers. This makes dynamic query counting, e.g. via exceedServFails(), useless for the usual repeating packet floods by misbehaving clients on similar FQDNs.
While it certainly has some performance impact I wonder if it would make sense to adjust the ring buffers so that they can also be used for proper counting of queries hitting the caches, potentially in a configurable way. Or look into a different solution for being able to handle excessive clients/queries without causing excessive performance impact.
If kept as is I think the current behavior might be missing some documentation at ringbuffers / dynamic blocks.
(As discussed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants