Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: 'Fake' entries inserted into the ring buffers on timeouts have wrong flags #11905

Closed
rgacogne opened this issue Sep 6, 2022 · 0 comments · Fixed by #12529
Closed

Comments

@rgacogne
Copy link
Member

rgacogne commented Sep 6, 2022

  • Program: dnsdist
  • Issue type: Bug report

Short description

When we detect a timeout while waiting for a UDP response from a backend, we insert a 'fake' entry into the ring buffers as a placeholder. This is useful to be able to look for which queries are causing a timeout using grepq(), among other things.
When we do that, we set the correct ID so that the response matches the query but we do not set the rest of the flags, which means RD does not show up in grepq(). We should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant