Accept NOTIFY from masters on non-standard port #219

Closed
Habbie opened this Issue Apr 26, 2013 · 4 comments

Projects

None yet

1 participant

@Habbie
Member
Habbie commented Apr 26, 2013

This is related to ticket 211 which adds support for masters on non-standard ports:

http://wiki.powerdns.com/cgi-bin/trac.fcgi/ticket/211

With the changes in that ticket, PowerDNS will accept the NOTIFY messages, but it would then attempt to do an SOA check on port 53 from the IP address that sent them. This of course does not work. :)

The attached patch changes the server so that it will use the port defined for the master as the target of the SOA check. (Note that it only does this for the SQL backend, and not the BIND backend. I don't think the BIND backend supports masters on non-standard ports.)

The ''right'' way to do this is probably to have the SOA check be handled in the code that performs the XFR. That way a NOTIFY would simply schedule an immediate zone update rather than perform the SOA check. But the method here works.

@Habbie Habbie was assigned Apr 26, 2013
@Habbie Habbie closed this Apr 26, 2013
@Habbie
Member
Habbie commented Apr 26, 2013

Attachment '' (notify-accept.diff) https://gist.github.com/5466655

@Habbie
Member
Habbie commented Apr 26, 2013

Attachment 'Incremental patch to apply after the patches in ticket #211' (notify-accept-incremental.diff) https://gist.github.com/5466656

@Habbie
Member
Habbie commented Apr 26, 2013

Author: anon
Oh, forgot to attribute this. You can send questions to the development list, or contact me directly at:

Shane Kerr [[BR]]
shane@ca.afilias-nst.info

@Habbie
Member
Habbie commented Apr 26, 2013

Author: peter
Presumably fixed when #211 got fixed in PowerDNS 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment