Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to dnsdist console prints 'Added downstream 0.0.0.0' #3257

Closed
ahupowerdns opened this issue Jan 18, 2016 · 2 comments
Closed

Connecting to dnsdist console prints 'Added downstream 0.0.0.0' #3257

ahupowerdns opened this issue Jan 18, 2016 · 2 comments

Comments

@ahupowerdns
Copy link
Contributor

@ahupowerdns ahupowerdns commented Jan 18, 2016

pi@raspberrypi ~/pdns/pdns/dnsdistdist $ sudo ./dnsdist -C plus.conf -c
Read configuration from 'plus.conf'
"Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0
Added downstream server 0.0.0.0:0"

This comes from the constructor, which also opens sockets and stuff. We should probably not be creating those objects in client mode.

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jan 18, 2016

I guess the reason we do is that newServer() returns a DownstreamState, so not returning anything might cause an error if the returned value is used later in the configuration. Do you think we should change that?

@ahupowerdns
Copy link
Contributor Author

@ahupowerdns ahupowerdns commented Jan 18, 2016

well, I don't know about the solution. I do know we are creating actual network connections to 0.0.0.0 now which is pretty odd in client mode. So a solution might be to recognize 'fake' entries?

rgacogne added a commit to rgacogne/pdns that referenced this issue Jan 19, 2016
While parsing the configuration in client mode, we create a fake
DownstreamState for each newServer() call, because we need it to
return a valid DownstreamState object. Unfortunately this leads
to the creation of a socket for 0.0.0.0, and a subsequent
connection attempt.
We now detect that the address does not make sense in this context
and do not create the associated socket.
Closes PowerDNS#3257.
rgacogne added a commit to rgacogne/pdns that referenced this issue Jan 19, 2016
While parsing the configuration in client mode, we create a fake
DownstreamState for each newServer() call, because we need it to
return a valid DownstreamState object. Unfortunately this leads
to the creation of a socket for 0.0.0.0, and a subsequent
connection attempt.
We now detect that the address does not make sense in this context
and do not create the associated socket.
Closes PowerDNS#3257.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants