Non-portable test in configure script #420

Closed
Habbie opened this Issue Apr 26, 2013 · 2 comments

Projects

None yet

1 participant

@Habbie
Member
Habbie commented Apr 26, 2013

The configure(.in) script contains the following test:

if test ${a} == "gpgsql"; then

However the "==" notation is a bash'ism, it is not a standard (POSIX) requirement for the "test" or "[" command to implement it. Worse, in many implementations this expression will unconditionally evaluate to false (without error), leading to unexpected behaviour.

Please change this to "=" for portable behaviour across POSIX Bourne shells. Patch attached.

@Habbie Habbie was assigned Apr 26, 2013
@Habbie Habbie closed this Apr 26, 2013
@Habbie
Member
Habbie commented Apr 26, 2013

Attachment '' (configure.patch) https://gist.github.com/5466726

@Habbie
Member
Habbie commented Apr 26, 2013

Author: peter
Applied in revision 2373, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment