Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: MacAddrAction() should handle EDNS-enabled queries #4670

Closed
rgacogne opened this issue Nov 9, 2016 · 1 comment · Fixed by #10907
Closed

dnsdist: MacAddrAction() should handle EDNS-enabled queries #4670

rgacogne opened this issue Nov 9, 2016 · 1 comment · Fixed by #10907

Comments

@rgacogne
Copy link
Member

rgacogne commented Nov 9, 2016

  • Program: dnsdist
  • Issue type: Feature request

Short description

Right now, MacAddrAction() does nothing if arcount != 0, which means that EDNS-enabled queries are not handled correctly. It would be nice to be able to add a new EDNS option while conserving the existing OPT RR. We should be able to reuse the existing code handling that case for the EDNS Client Subnet option.

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Nov 9, 2016
pieterlexis added a commit that referenced this issue Dec 27, 2016
Backport #4670: Set `RemoteLogger::d_socket` to -1 after closing it
@rgacogne rgacogne modified the milestones: dnsdist-1.3.0, dnsdist-1.2.0 Aug 3, 2017
@rgacogne rgacogne modified the milestones: dnsdist-1.3.0, dnsdist-1.4.0 Mar 27, 2018
@rgacogne rgacogne modified the milestones: dnsdist-1.4.0, dnsdist-1.5.0 Apr 10, 2019
@rgacogne rgacogne modified the milestones: dnsdist-1.5.0, dnsdist-1.6.0 Feb 11, 2020
@rgacogne rgacogne modified the milestones: dnsdist-1.6.0, dnsdist-1.7.0 Nov 26, 2020
@rgacogne
Copy link
Member Author

Same for SetEDNSOptionAction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant