Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: sort includeDirectory() #5053

Closed
mikalsande opened this issue Feb 19, 2017 · 0 comments
Closed

Feature request: sort includeDirectory() #5053

mikalsande opened this issue Feb 19, 2017 · 0 comments

Comments

@mikalsande
Copy link

@mikalsande mikalsande commented Feb 19, 2017

  • Program: dnsdist
  • Issue type: Feature request

Short description

The includeDirectory() directory loads configuration files in directory order, as show by 'ls -U'. The effect is that the load order of config files can change between restarts of dnsdist if files have been created or moved in the included directory.

Environment

Steps to reproduce

  1. Create three config files (1.conf, 2.conf and 3.conf) with addAction() rules, such as
  • addAction(AndRule({RE2Rule('1.com')}), DropAction())
  1. include the config files with the includeDirectory() directive
  2. Restart dnsdist
  3. showRules() will show that the rules were loaded in the same order as 'ls -U' in the included directory

Expected behaviour

Config files loaded in a consistent and sorted order.

Actual behaviour

Config files loaded in directory order, 'ls -U'.

Usecase

Having config files included into the main config in a predictable manner is important for maintaining a consistent rule order when splitting rules accross several config files.

@mikalsande mikalsande changed the title Feature request: sort Feature request: sort includeDirectory() Feb 19, 2017
@Habbie Habbie added this to the dnsdist-1.2.0 milestone Mar 7, 2017
rgacogne added a commit that referenced this issue Mar 15, 2017
dnsdist: Make includeDirectory work sorted #5053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants