Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove dnsdist syntactic sugar functions #5069

pieterlexis opened this issue Feb 22, 2017 · 2 comments

Deprecate and remove dnsdist syntactic sugar functions #5069

pieterlexis opened this issue Feb 22, 2017 · 2 comments


Copy link

@pieterlexis pieterlexis commented Feb 22, 2017

  • Program: dnsdist
  • Issue type: Feature request

Short description

Right now there are multiple ways of accomplishing the same things in dnsdist. For instance

addQPSLimit(AllRule(), qps) == addAction(AllRule(), QPSAction(qps)) == addAction(MaxQPSRule(qps), DropAction()) 

Functions like setDNSSECPool, addDomainSpoof and addPoolRule can be mimicked with a 'normal' set of Rules and Actions. (e.g. setDNSSECPool == addAction(DNSSECRule(), poolAction())).

Forcing users to to be a little bit more explicit (using addAction, addResponseAction etc.) makes for a cleaner and better to understand configuration.


Simplify initial understanding of how dnsdist's Rules and Actions hang together and ensure understandability of the configuration

@rgacogne rgacogne added this to the dnsdist-1.2.0 milestone Feb 22, 2017
Copy link

@ahupowerdns ahupowerdns commented Apr 7, 2017

so I applaud this in theory, but we should document explicitly that addAction() accepts domain names, ip addresses and even lists of domain names and IP addresses as its first argument. It is (technically) documented now, but it appears in no example!

Copy link

@rgacogne rgacogne commented Aug 14, 2017

Done in #5526.

@rgacogne rgacogne closed this Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants