New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize 0x20 queries in dnsdist statistics #5287

Closed
mikedamm opened this Issue May 3, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@mikedamm

mikedamm commented May 3, 2017

  • Program: dnsdist
  • Issue type: Bug report

Short description

dnsdist copies the QNAME as sent by the client into the buffer used for generating statistics. As a result a client sending 0x20 queries generates odd output in topQueries().

Environment

  • Operating system: Ubuntu 16.04
  • Software version: 1.1.0
  • Software source: pdns repo

Other information

Example from production:

> topQueries(1000)
 100  0.conTRol4.Pool.NTp.org.                   13  0.1%
 135  MX.pool.ntp.org.                            6  0.1%
 198  1.lEDe.pOoL.ntP.oRg.                        2  0.0%
 246  _ntp._UdP.SG.POOL.NtP.Org.                  1  0.0%
 272  0.XX.pool.ntp.org.                          1  0.0%
 275  1.fReEbsd.pOol.nTP.Org.                     1  0.0%
 276  0.Se.pool.ntp.Org.                          1  0.0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment