dnsdist: signed/unsigned comparison warning

[pieterlexis]

• Program: dnsdist
• Issue type: Bug report

Short description

it looks like the TimedIPSetRule does signed/unsigned comparisons:

In file included from dnsdist-lua.cc:26:0:
dnsrulactions.hh: In member function ‘virtual bool TimedIPSetRule::matches(const DNSQuestion*) const’:
dnsrulactions.hh:167:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       return time(0) < fnd->second;
                      ^
dnsrulactions.hh:174:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       return time(0) < fnd->second;
                      ^
dnsrulactions.hh: In member function ‘void TimedIPSetRule::cleanup()’:
dnsrulactions.hh:224:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  if(iter->second < now)
                  ^
dnsrulactions.hh:236:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  if(iter->second < now)
                  ^
dnsrulactions.hh: In member function ‘virtual std::string TimedIPSetRule::toString() const’:
dnsrulactions.hh:253:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if(now < ip.second)
                ^
dnsrulactions.hh:259:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if(now < ip.second)
                ^

Found when building dnsdist on raspbian (ARM)

[pieterlexis]

Another one:

dnsdist-tcp.cc: In function ‘bool maxConnectionDurationReached(unsigned int, time_t, unsigned int&)’:
dnsdist-tcp.cc:194:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (elapsed >= maxConnectionDuration) {
                 ^