Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 addresses improperly encoded in carbon metrics #5538

Closed
mikedamm opened this issue Jul 18, 2017 · 0 comments · Fixed by #5579
Closed

IPv6 addresses improperly encoded in carbon metrics #5538

mikedamm opened this issue Jul 18, 2017 · 0 comments · Fixed by #5579
Labels
defect dnsdist
Milestone
dnsdist-1.2.0

Comments

@mikedamm
Copy link
Contributor

  • Program: dnsdist
  • Issue type: Bug report

Short description

When logging to carbon, IPv6 addresses are enclosed in square brackets ([]) within metric names. Square brackets have special meaning to many storage engines and frontends.

Environment

  • Operating system: Ubuntu 16.04
  • Software version: dnsdist 1.1.0
  • Software source: repo

Steps to reproduce

  1. Configure dnsdist with an IPv6 interface and logging to a carbon server
  2. Observe the metric names within your carbon instance
  3. IPv4 addresses are encoded as 10_0_0_1:53_tcp, IPv6 addresses are encoded as [2001:db8::1]:53_tcp

Expected behaviour

A recommended encoding would be 2001:db8::1_53_tcp. It is really a toss-up on the colons becoming ambiguous or breaking with the v4 encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.2.0
Development

Successfully merging a pull request may close this issue.

dnsdist: Don't use square brackets for IPv6 in Carbon metrics rgacogne/pdns
2 participants
@mikedamm @rgacogne