Skip to content

dnsdist: show a subset of the rule if the rule is huge #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giganteous opened this issue Oct 3, 2017 · 0 comments · Fixed by #6402
Closed

dnsdist: show a subset of the rule if the rule is huge #5763

giganteous opened this issue Oct 3, 2017 · 0 comments · Fixed by #6402

Comments

@giganteous
Copy link
Contributor

giganteous commented Oct 3, 2017

  • Program: dnsdist
  • Issue type: Feature request

Short description

The dnsdist dashboard and the showRules() output are almost unreadable when the rules get large.

Usecase

We autogenerate an action with puppet which looks a bit like:

addAction(OrRule({
    QNameRule("accesspiratebay.co.uk"),
    QNameRule("fastpiratebay.co.uk"),
    QNameRule("gameofbay.org"),
    QNameRule("hyperproxy.net"),
    QNameRule("ikwilthepiratebay.org"),
    QNameRule("kanyebay.co.uk"),
    QNameRule("openpiratebay.eu"),
    QNameRule("pirateaccess.info"),
....

and it results in this:

> showRules()
#     Matches Rule                                               Action
0         791 (qname==accesspiratebay.co.uk.) || (qname==fastpiratebay.co.uk.) || (qname==gameofbay.org.) || (qname==hyperproxy.net.) || (qname==ikwilthepiratebay.org.) || (qname==kanyebay.co.uk.) || (qname==openpiratebay.eu.) || (qname==pirateaccess.info.) || (qname==pirateaccess.xyz.) || (qname==piratebayaccess.co.uk.) || (qname==piratebayblocked.com.) || (qname==piratebay.click.) || (qname==piratebay.co.in.) || (qname==piratebayfast.co.uk.) || (qname==piratebaymirror.eu.) || (qname==piratebaynew.co.uk.) || (qname==piratebay.party.) || (qname==piratebayportal.co.uk.) || (qname==piratebayproxy.tf.) || (qname==piratebayquick.co.uk.) || (qname==piratebay.red.) || (qname==piratebay.run.) || (qname==piratebays.co.) || (qname==piratebays.co.uk.) || (qname==piratebay.unblocked.lol.) || (qname==piratebay.website.) || (qname==piratebay.zone.) || (qname==pirateportal.xyz.) || (qname==pirateproxy.cc.) || (qname==pirateproxy.click.) || (qname==pirateproxy.tf.) || (qname==pirateproxy.website.) || (qname==pirateproxy.wf.) || (qname==pirateproxy.yt.) || (qname==pirate.trade.) || (qname==pirateunblocker.info.) || (qname==proxyspotting.in.) || (qname==thebay.tv.) || (qname==thehiddenbay.cc.) || (qname==thehiddenbay.info.) || (qname==themagnetbay.pro.) || (qname==thepbay.ga.) || (qname==thepiratebay24.ga.) || (qname==thepiratebay.ae.) || (qname==thepiratebay.ae.org.) || (qname==thepiratebay.asia.) || (qname==thepiratebay.bid.) || (qname==thepiratebay.bypassed.cab.) || (qname==thepiratebay.bypassed.plus.) || (qname==thepiratebay.bypassed.team.) || (qname==thepiratebay.cool.) || (qname==thepiratebay.cr.) || (qname==thepiratebay.immunicity.cab.) || (qname==thepiratebay.immunicity.plus.) || (qname==thepiratebay.immunicity.team.) || (qname==thepiratebay.life.) || (qname==thepiratebayonline.top.) || (qname==thepiratebay.org.) || (qname==thepiratebay-org.pbproxy.red.) || (qname==thepiratebay-org.proxydude.xyz.) || (qname==thepiratebay-proxy.com.) || (qname==thepiratebay-proxy.xyz.) || (qname==thepiratebay.red.) || (qname==thepiratebay.rocks.) || (qname==thepiratebay.run.) || (qname==thepiratebay.se.) || (qname==thepiratebay-se.com.) || (qname==thepiratebay.technology.) || (qname==thepiratebay.uk.net.) || (qname==thepiratebay.unblockall.xyz.) || (qname==thepiratebay.unblockall.cab.) || (qname==thepiratebay.unblockall.plus.) || (qname==thepiratebay.unblockall.team.) || (qname==thepiratebay.world.) || (qname==thepiratebay.za.bz.) || (qname==thepiratebayz.org.) || (qname==thepiratebeach.eu.) || (qname==thepirateproxy.gq.) || (qname==theproxybay.me.) || (qname==torrents.rocks.) || (qname==tpbclean.pro.) || (qname==tpb.dashitz.com.) || (qname==tpb.dbpotato.net.) || (qname==tpb.me.uk.) || (qname==tpbmirror.us.) || (qname==tpbonion.com.) || (qname==tpb.pm.) || (qname==tpb.portalimg.com.) || (qname==tpb.proxyduck.info.) || (qname==tpbproxy.eu.) || (qname==tpbproxy.org.) || (qname==tpb.tw.) || (qname==tpbunblocked.org.) || (qname==tpb.zone.) || (qname==uj3wazyk5u4hnvtk.online.) || (qname==ukpirate.click.) || (qname==ukpirate.org.) || (qname==ukpirateproxy.xyz.) || (qname==uktpbproxy.info.) || (qname==unblockedbay.info.) || (qname==unblocktpb.com.) || (qname==unblocktpb.pro.) || (qname==urbanproxy.eu.) || (qname==www.accesspiratebay.co.uk.) || (qname==www.ikwilthepiratebay.org.) || (qname==www.kanyebay.co.uk.) || (qname==www.openpiratebay.eu.) || (qname==www.pirateaccess.info.) || (qname==www.pirateaccess.xyz.) || (qname==www.piratebayaccess.co.uk.) || (qname==www.piratebayblocked.com.) || (qname==www.piratebay.co.in.) || (qname==www.piratebayfast.co.uk.) || (qname==www.piratebaynew.co.uk.) || (qname==www.piratebay.party.) || (qname==www.piratebayportal.co.uk.) || (qname==www.piratebayquick.co.uk.) || (qname==www.piratebay.run.) || (qname==www.piratebay.zone.) || (qname==www.pirateportal.xyz.) || (qname==www.pirateproxy.cc.) || (qname==www.pirateproxy.website.) || (qname==www.pirateunblocker.info.) || (qname==www.thehiddenbay.cc.) || (qname==www.themagnetbay.pro.) || (qname==www.thepiratebay24.ga.) || (qname==www.thepiratebay.ae.) || (qname==www.thepiratebay.ae.org.) || (qname==www.thepiratebay.asia.) || (qname==www.thepiratebay.bid.) || (qname==www.thepiratebay.cr.) || (qname==www.thepiratebay.org.) || (qname==www.thepiratebay-proxy.xyz.) || (qname==www.thepiratebay.red.) || (qname==www.thepiratebay.rocks.) || (qname==www.thepiratebay.run.) || (qname==www.thepiratebay.se.) || (qname==www.thepiratebay-se.com.) || (qname==www.thepiratebay.technology.) || (qname==www.thepiratebay.za.bz.) || (qname==www.thepiratebayz.org.) || (qname==www.thepiratebeach.eu.) || (qname==www.thepirateproxy.gq.) || (qname==www.theproxybay.me.) || (qname==www.torrents.rocks.) || (qname==www.tpbclean.pro.) || (qname==www.tpb.me.uk.) || (qname==www.tpbonion.com.) || (qname==www.tpb.pm.) || (qname==www.tpbproxy.eu.) || (qname==www.tpbproxy.org.) || (qname==www.tpb.zone.) || (qname==www.uj3wazyk5u4hnvtk.online.) || (qname==www.uktpbproxy.info.) || (qname==www.unblocktpb.pro.) spoof in 194.109.6.92 2001:888:0:18::80 

Description

Perhaps support a show rule command with an argument to give more details, or support giving it a label. While implementing this, think about indempotent setting of certain rules remote using the CLI or API: Zero downtime changes to rules would be interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants