Auth: b2b-migrate from BIND to gsqlite does not migrate 'master' servers

[pieterlexis]

• Program: Authoritative
• Issue type: Bug report

Short description

While migrating from the BIND backend to the gsqlite3 backend, the IP addresses of the masters for slave zones are not added to the database's "masters" column in the "domains" table.

Environment

• Operating system: Debian Stretch
• Software version: Master (2b55d75)
• Software source: repo.powerdns.com

Steps to reproduce

1. Have a slave zone in the bind backend:

zone "powerdns.space" in {
  type slave;
  file "/var/lib/powerdns/zones/powerdns.space.zone";
  masters {
    188.166.104.87;
    2a03:b0c0:2:d0::4af:b001;
  };
};

2. Run pdnsutil b2b-migrate bind gsqlite3 (after configging both backends in pdns.conf)
3. Observe no masters in the domains table:

$ sqlite3 -column -header /var/lib/powerdns/pdns-public.sqlite3 "select * from domains where name='powerdns.space'"
id          name            master      last_check  type        notified_serial  account   
----------  --------------  ----------  ----------  ----------  ---------------  ----------
7           powerdns.space                          SLAVE                                  

Expected behaviour

That the master IP addresses show up in the table.

Actual behaviour

That the addresses did not show up.